Qpid
  1. Qpid
  2. QPID-4051

[Java client] the 'connecttimeout' ConnectionURL option is no longer effective

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
    • Fix Version/s: 0.19
    • Component/s: Java Client
    • Labels:
      None

      Description

      The 'connecttimeout' ConnectionURL option is no longer effective.

      It appears that the option was only ever used for the 0-8/0-9/0-9-1 client path, but its use there was broken with I/O updates made in 2009 (apparently here: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/transport/SocketTransportConnection.java?r1=726140&r2=825362&pathrev=1143866&diff_format=h) before Qpid 0.6 went out and presumably it has been unused ever since.

      QPID-4047 introduced a fixed timeout on the socket connect call (affecting all protocol versions), but we should restore the 'connecttimeout' option to make it configurable again.

        Activity

        Hide
        Robbie Gemmell added a comment -
        Show
        Robbie Gemmell added a comment - Change committed in r1372147: http://svn.apache.org/viewvc?view=revision&revision=1372147
        Hide
        Robbie Gemmell added a comment -

        Keith, could you review this change please?

        Thanks,
        Robbie

        Show
        Robbie Gemmell added a comment - Keith, could you review this change please? Thanks, Robbie
        Hide
        Keith Wall added a comment -

        Hi Robbie,

        No comments against the code/tests, but I thing we should add a sentence to the Programming in Apache Qpid docbook describing the behaviour of zero. It should have words to the effect of "A timeout of zero is interpreted as an infinite timeout. The connection will then block until established or an error occurs."

        http://qpid.apache.org/books/trunk/Programming-In-Apache-Qpid-Book/html/QpidJNDI.html#section-jms-connection-url

        Show
        Keith Wall added a comment - Hi Robbie, No comments against the code/tests, but I thing we should add a sentence to the Programming in Apache Qpid docbook describing the behaviour of zero. It should have words to the effect of "A timeout of zero is interpreted as an infinite timeout. The connection will then block until established or an error occurs." http://qpid.apache.org/books/trunk/Programming-In-Apache-Qpid-Book/html/QpidJNDI.html#section-jms-connection-url
        Hide
        Robbie Gemmell added a comment -

        Documentation updated as suggested in http://svn.apache.org/viewvc?view=revision&revision=1373596

        Closing out.

        Show
        Robbie Gemmell added a comment - Documentation updated as suggested in http://svn.apache.org/viewvc?view=revision&revision=1373596 Closing out.

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development