Qpid
  1. Qpid
  2. QPID-4009

Make failover method invocation timeout configurable for 0-8/0-9/0-9-1 amqp clients

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.17
    • Fix Version/s: 0.17
    • Component/s: Java Client
    • Labels:
      None

      Description

      When connection is lost and failover is configured, on 0-8/0-9/0-9-1 code paths the failover thread is started to restore the connection. The failover thread tries to acquire a failover mutex to re-establish the connection. In some occasions the failover mutex can be hold in JMS methods for a time longer than failover timeout (for example, sending of message with producer flow control on when flow is blocked). As result of it, the failover process is aborted and connection is closed.

      Making the failover method invocation timeout configurable would allows us to work around the issue described above by increasing the failover timeout.

      The proper fix of this issue would be making of failover occurrence absolutely transparent for the client code.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        5d 3h 54m 1 Alex Rudyy 23/May/12 15:39
        In Progress In Progress Reviewable Reviewable
        1m 37s 1 Alex Rudyy 23/May/12 15:41
        Reviewable Reviewable Resolved Resolved
        5d 20h 7m 1 Robbie Gemmell 29/May/12 11:49
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Robbie Gemmell added a comment -

        Patch applied, along with some updates from joint review with Phil.

        Show
        Robbie Gemmell added a comment - Patch applied, along with some updates from joint review with Phil.
        Alex Rudyy made changes -
        Alex Rudyy made changes -
        Attachment 0001-QPID-4009-Make-failover-method-invocation-timeout-co.patch [ 12528744 ]
        Alex Rudyy made changes -
        Assignee Alex Rudyy [ alex.rufous ] Philip Harvey [ philharveyonline ]
        Hide
        Alex Rudyy added a comment -

        Phil,

        Could you please review the patch attached?

        Show
        Alex Rudyy added a comment - Phil, Could you please review the patch attached?
        Alex Rudyy made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Alex Rudyy made changes -
        Attachment 0001-QPID-4009-Make-failover-method-invocation-timeout-co.patch [ 12528744 ]
        Hide
        Alex Rudyy added a comment -

        Attached a patch making timeout configurable

        Show
        Alex Rudyy added a comment - Attached a patch making timeout configurable
        Alex Rudyy made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Alex Rudyy created issue -

          People

          • Assignee:
            Philip Harvey
            Reporter:
            Alex Rudyy
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development