[QPID-4004] Cruft in qpid::framing::Buffer class should be removed

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.17
• Component/s: C++ Broker
• Assignee: Andrew Stitcher
• Reporter: Florian Weimer
• Created: 16/May/12 15:53
• Updated: 29/Jul/13 19:05
• Resolved: 16/May/12 21:01

Description

The definition of qpid::framing::Buffer::Iterator seems buggy to me. This is not a bidirectional iterator. It's not even a forward iterator because the iterator state is kept in the referenced buffer object. It is not possible to use a pair of such iterators to form a range, so not many algorithms can be used on them (at least not in a safe manner).