Qpid
  1. Qpid
  2. QPID-4004

Cruft in qpid::framing::Buffer class should be removed

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.17
    • Component/s: C++ Broker
    • Labels:
      None

      Description

      The definition of qpid::framing::Buffer::Iterator seems buggy to me. This is not a bidirectional iterator. It's not even a forward iterator because the iterator state is kept in the referenced buffer object. It is not possible to use a pair of such iterators to form a range, so not many algorithms can be used on them (at least not in a safe manner).

        Activity

        Justin Ross made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Andrew Stitcher made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 0.17 [ 12320179 ]
        Resolution Fixed [ 1 ]
        Andrew Stitcher made changes -
        Summary qpid::framing::Buffer::Iterator not very useful Cruft in qpid::framing::Buffer class should be removed
        Andrew Stitcher made changes -
        Field Original Value New Value
        Assignee Andrew Stitcher [ astitcher ]
        Florian Weimer created issue -

          People

          • Assignee:
            Andrew Stitcher
            Reporter:
            Florian Weimer
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development