Qpid
  1. Qpid
  2. QPID-3974

replication exchange msgDrop and byteDrop to increase when duplicate messages detected

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.14
    • Fix Version/s: 0.17
    • Component/s: C++ Broker
    • Labels:

      Description

      Description of problem:
      When replication exchange detects duplicated messages, it 1) discards them, and
      2) as for any other message, it increases msgIn and byteIn counters. But
      msgDrop and byteDrop counters are not updated, though the messages were
      discarded.

      Version-Release number of selected component (if applicable):
      any (incl. 0.14)

      How reproducible:
      100%

      Steps to Reproduce:
      1. Setup queue state replication, like
      https://cwiki.apache.org/qpid/queue-state-replication.html.
      2. Produce 5 messages to the queue-a on the source broker.
      3. Restart source broker.
      4. Produce another 3 messages to the queue-a on the source broker.

      Actual results:
      Destination broker (replication exchange in particular) drops the messages
      (though these are not duplicates of previously sent - new BZ to be open for
      that). Replication exchange increases msgIn and byteIn counters but does not
      increase msgDrop and byteDrop counters.

      Expected results:
      msgDrop and byteDrop counters are also increased.

      Additional info:
      Patch to be proposed.

        Activity

        Pavel Moravec created issue -
        Pavel Moravec made changes -
        Field Original Value New Value
        Description Description of problem:
        When replication exchange detects duplicated messages, it 1) discards them, and
        2) as for any other message, it increases msgIn and byteIn counters. But
        msgDrop and byteDrop counters are not updated, though the messages were
        discarded.


        Version-Release number of selected component (if applicable):
        any (incl. 0.14)


        How reproducible:
        100%


        Steps to Reproduce:
        1. Setup queue state replication, like
        https://cwiki.apache.org/qpid/queue-state-replication.html.
        2. Produce 3 messages to the queue-a on the source broker.
        3. Restart source broker.
        4. Produce another 5 messages to the queue-a on the source broker.


        Actual results:
        Destination broker (replication exchange in particular) drops the messages
        (though these are not duplicates of previously sent - new BZ to be open for
        that). Replication exchange increases msgIn and byteIn counters but does not
        increase msgDrop and byteDrop counters.


        Expected results:
        msgDrop and byteDrop counters are also increased.


        Additional info:
        Patch to be proposed.
        Description of problem:
        When replication exchange detects duplicated messages, it 1) discards them, and
        2) as for any other message, it increases msgIn and byteIn counters. But
        msgDrop and byteDrop counters are not updated, though the messages were
        discarded.


        Version-Release number of selected component (if applicable):
        any (incl. 0.14)


        How reproducible:
        100%


        Steps to Reproduce:
        1. Setup queue state replication, like
        https://cwiki.apache.org/qpid/queue-state-replication.html.
        2. Produce 5 messages to the queue-a on the source broker.
        3. Restart source broker.
        4. Produce another 3 messages to the queue-a on the source broker.


        Actual results:
        Destination broker (replication exchange in particular) drops the messages
        (though these are not duplicates of previously sent - new BZ to be open for
        that). Replication exchange increases msgIn and byteIn counters but does not
        increase msgDrop and byteDrop counters.


        Expected results:
        msgDrop and byteDrop counters are also increased.


        Additional info:
        Patch to be proposed.
        Hide
        Pavel Moravec added a comment -

        Patch proposal.

        When isDuplicate(args) is called and returns true, mgmtExchange->inc_msgDrops and mgmtExchange->inc_msgBytes is called (if it is set up).

        Show
        Pavel Moravec added a comment - Patch proposal. When isDuplicate(args) is called and returns true, mgmtExchange->inc_msgDrops and mgmtExchange->inc_msgBytes is called (if it is set up).
        Pavel Moravec made changes -
        Attachment ReplicationDuplMsgIncrement.patch [ 12524166 ]
        Hide
        Gordon Sim added a comment -

        Thanks Pavel!

        Show
        Gordon Sim added a comment - Thanks Pavel!
        Gordon Sim made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Gordon Sim [ gsim ]
        Fix Version/s 0.17 [ 12320179 ]
        Resolution Fixed [ 1 ]
        Justin Ross made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Gordon Sim
            Reporter:
            Pavel Moravec
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development