Qpid
  1. Qpid
  2. QPID-3969

arguments for QMFv2 methods may have undefined values if not specified

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.16
    • Fix Version/s: 0.17
    • Labels:
      None

      Description

      E.g. if you invoke reroute on a queue (in the c++ broker) and do not specify a value for use-alt-exchange, the actual value for that variable is undefined. The same is true for all bool and int arguments.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4845/
        -----------------------------------------------------------

        Review request for Ted Ross.

        Summary
        -------

        Arguments for QMFv2 methods may have undefined values if not specified. E.g. if you invoke reroute on a queue (in the c++ broker) and do not specify a value for use-alt-exchange, the actual value for that variable is undefined. The same is true for all bool and int arguments.

        This addresses bug QPID-3969.
        https://issues.apache.org/jira/browse/QPID-3969

        Diffs


        /trunk/qpid/cpp/managementgen/qmfgen/schema.py 1329397

        Diff: https://reviews.apache.org/r/4845/diff

        Testing
        -------

        make check passes

        Thanks,

        Gordon

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4845/ ----------------------------------------------------------- Review request for Ted Ross. Summary ------- Arguments for QMFv2 methods may have undefined values if not specified. E.g. if you invoke reroute on a queue (in the c++ broker) and do not specify a value for use-alt-exchange, the actual value for that variable is undefined. The same is true for all bool and int arguments. This addresses bug QPID-3969 . https://issues.apache.org/jira/browse/QPID-3969 Diffs /trunk/qpid/cpp/managementgen/qmfgen/schema.py 1329397 Diff: https://reviews.apache.org/r/4845/diff Testing ------- make check passes Thanks, Gordon
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4845/#review7175
        -----------------------------------------------------------

        I'd like to propose a more general solution to this problem (I'll create a separate review as I don't see a way to attach a patch to this review).

        The schema syntax allows for the specification of a default value for input arguments and the type-definition file already has an "init" field for the default value of a type. I propose that the "unmap" generated code use the argument default, if present, otherwise the default initializer for the data type.

        • Ted

        On 2012-04-23 20:50:04, Gordon Sim wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4845/

        -----------------------------------------------------------

        (Updated 2012-04-23 20:50:04)

        Review request for Ted Ross.

        Summary

        -------

        Arguments for QMFv2 methods may have undefined values if not specified. E.g. if you invoke reroute on a queue (in the c++ broker) and do not specify a value for use-alt-exchange, the actual value for that variable is undefined. The same is true for all bool and int arguments.

        This addresses bug QPID-3969.

        https://issues.apache.org/jira/browse/QPID-3969

        Diffs

        -----

        /trunk/qpid/cpp/managementgen/qmfgen/schema.py 1329397

        Diff: https://reviews.apache.org/r/4845/diff

        Testing

        -------

        make check passes

        Thanks,

        Gordon

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4845/#review7175 ----------------------------------------------------------- I'd like to propose a more general solution to this problem (I'll create a separate review as I don't see a way to attach a patch to this review). The schema syntax allows for the specification of a default value for input arguments and the type-definition file already has an "init" field for the default value of a type. I propose that the "unmap" generated code use the argument default, if present, otherwise the default initializer for the data type. Ted On 2012-04-23 20:50:04, Gordon Sim wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4845/ ----------------------------------------------------------- (Updated 2012-04-23 20:50:04) Review request for Ted Ross. Summary ------- Arguments for QMFv2 methods may have undefined values if not specified. E.g. if you invoke reroute on a queue (in the c++ broker) and do not specify a value for use-alt-exchange, the actual value for that variable is undefined. The same is true for all bool and int arguments. This addresses bug QPID-3969 . https://issues.apache.org/jira/browse/QPID-3969 Diffs ----- /trunk/qpid/cpp/managementgen/qmfgen/schema.py 1329397 Diff: https://reviews.apache.org/r/4845/diff Testing ------- make check passes Thanks, Gordon
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4855/
        -----------------------------------------------------------

        Review request for Gordon Sim.

        Summary
        -------

        This is a more general solution than the original patch.

        This addresses bug QPID-3969.
        https://issues.apache.org/jira/browse/QPID-3969

        Diffs


        trunk/qpid/cpp/managementgen/qmfgen/management-types.xml 1329233
        trunk/qpid/cpp/managementgen/qmfgen/schema.py 1329233
        trunk/qpid/specs/management-schema.xml 1329233

        Diff: https://reviews.apache.org/r/4855/diff

        Testing
        -------

        running make check currently

        Thanks,

        Ted

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4855/ ----------------------------------------------------------- Review request for Gordon Sim. Summary ------- This is a more general solution than the original patch. This addresses bug QPID-3969 . https://issues.apache.org/jira/browse/QPID-3969 Diffs trunk/qpid/cpp/managementgen/qmfgen/management-types.xml 1329233 trunk/qpid/cpp/managementgen/qmfgen/schema.py 1329233 trunk/qpid/specs/management-schema.xml 1329233 Diff: https://reviews.apache.org/r/4855/diff Testing ------- running make check currently Thanks, Ted
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4855/#review7177
        -----------------------------------------------------------

        Ship it!

        That seems better!

        • Gordon

        On 2012-04-24 14:28:17, Ted Ross wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4855/

        -----------------------------------------------------------

        (Updated 2012-04-24 14:28:17)

        Review request for Gordon Sim.

        Summary

        -------

        This is a more general solution than the original patch.

        This addresses bug QPID-3969.

        https://issues.apache.org/jira/browse/QPID-3969

        Diffs

        -----

        trunk/qpid/cpp/managementgen/qmfgen/management-types.xml 1329233

        trunk/qpid/cpp/managementgen/qmfgen/schema.py 1329233

        trunk/qpid/specs/management-schema.xml 1329233

        Diff: https://reviews.apache.org/r/4855/diff

        Testing

        -------

        running make check currently

        Thanks,

        Ted

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4855/#review7177 ----------------------------------------------------------- Ship it! That seems better! Gordon On 2012-04-24 14:28:17, Ted Ross wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4855/ ----------------------------------------------------------- (Updated 2012-04-24 14:28:17) Review request for Gordon Sim. Summary ------- This is a more general solution than the original patch. This addresses bug QPID-3969 . https://issues.apache.org/jira/browse/QPID-3969 Diffs ----- trunk/qpid/cpp/managementgen/qmfgen/management-types.xml 1329233 trunk/qpid/cpp/managementgen/qmfgen/schema.py 1329233 trunk/qpid/specs/management-schema.xml 1329233 Diff: https://reviews.apache.org/r/4855/diff Testing ------- running make check currently Thanks, Ted

          People

          • Assignee:
            Gordon Sim
            Reporter:
            Gordon Sim
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development