[QPID-3932] HA library links to non-existant broker::SignalHandler::shutdown()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.17
• Fix Version/s: 0.17
• Component/s: C++ Broker

Environment

Windows, Visual Studio

• Assignee: Stephen D. Huston
• Reporter: Stephen D. Huston
• Created: 04/Apr/12 20:07
• Updated: 29/Jul/13 18:54
• Resolved: 04/Apr/12 21:20

Description

There is a recently started build error on Windows:
HaBroker.obj : error LNK2019: unresolved external symbol "public: static void __cdecl qpid::broker::SignalHandler::shutdown(void)"

The missing symbol is in qpid/broker/SignalHandler.(h cpp) which appear to not be meant to be used on Windows. So the normal easy fix of adding a QPID_BROKER_EXTERN won't work. There are two issues:

1. The qpid/broker/SignalHandler.cpp file is POSIX-specific since it uses signal handlers. Therefore, it should be in qpid/broker/posix, not qpid/broker

2a. Should HA be building on Windows?

2. The HaBroker module needs some sort of shutdown mechanism for Windows, probably a Windows equivalent of the above SignalHandler.cpp - note that the windows/QpiddBroker.cpp has this type of shutdown in it. Maybe it should be worked into a form useable by HaBroker?

Could the experts in these areas comment please?