Qpid
  1. Qpid
  2. QPID-3932

HA library links to non-existant broker::SignalHandler::shutdown()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.17
    • Fix Version/s: 0.17
    • Component/s: C++ Broker
    • Labels:
      None
    • Environment:

      Windows, Visual Studio

      Description

      There is a recently started build error on Windows:
      HaBroker.obj : error LNK2019: unresolved external symbol "public: static void __cdecl qpid::broker::SignalHandler::shutdown(void)"

      The missing symbol is in qpid/broker/SignalHandler.(h cpp) which appear to not be meant to be used on Windows. So the normal easy fix of adding a QPID_BROKER_EXTERN won't work. There are two issues:

      1. The qpid/broker/SignalHandler.cpp file is POSIX-specific since it uses signal handlers. Therefore, it should be in qpid/broker/posix, not qpid/broker

      2a. Should HA be building on Windows?

      2. The HaBroker module needs some sort of shutdown mechanism for Windows, probably a Windows equivalent of the above SignalHandler.cpp - note that the windows/QpiddBroker.cpp has this type of shutdown in it. Maybe it should be worked into a form useable by HaBroker?

      Could the experts in these areas comment please?

        Activity

        Hide
        Steve Huston added a comment -

        Patch applied at trunk r1309600.
        Thanks!

        Show
        Steve Huston added a comment - Patch applied at trunk r1309600. Thanks!
        Hide
        Chuck Rolke added a comment -

        Use the broker's native shutdown() function.

        Show
        Chuck Rolke added a comment - Use the broker's native shutdown() function.

          People

          • Assignee:
            Steve Huston
            Reporter:
            Steve Huston
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development