Qpid
  1. Qpid
  2. QPID-3920

Occasional header corruption observed in federated system

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.16
    • Fix Version/s: 0.16
    • Component/s: C++ Broker
    • Labels:
      None

      Description

      While repeatedly running the federated unit tests, a client will receive a message with a corrupt header. Example:

      Running federation tests using brokers on ports 56253 34505 39575 59519
      federation.FederationTests.test_dynamic_topic_bounce .................................................................................................................................................. start
      Exception in thread Thread-1:
      Traceback (most recent call last):
      File "/usr/lib64/python2.7/threading.py", line 552, in __bootstrap_inner
      self.run()
      File "/usr/lib64/python2.7/threading.py", line 505, in run
      self._target(*self.args, **self._kwargs)
      File "/home/kgiusti/Desktop/work/qpid/git/apache/qpid/build/0.16/src/tests/python/qpid/connection.py", line 186, in run
      op_dec.write(*seg_dec.read())
      File "/home/kgiusti/Desktop/work/qpid/git/apache/qpid/build/0.16/src/tests/python/qpid/framing.py", line 271, in write
      self.op.headers.extend(self.decode_headers(seg.payload))
      File "/home/kgiusti/Desktop/work/qpid/git/apache/qpid/build/0.16/src/tests/python/qpid/framing.py", line 303, in decode_headers
      result.append(sc.read_struct32())
      File "/home/kgiusti/Desktop/work/qpid/git/apache/qpid/build/0.16/src/tests/python/qpid/codec010.py", line 308, in read_struct32
      cls = COMPOUND[code]
      KeyError: 3192

      federation.FederationTests.test_dynamic_topic_bounce .................................................................................................................................................. fail

        Activity

        Justin Ross made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Ken Giusti made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Justin Ross added a comment -

        Reviewed by Alan. Approved for 0.16.

        Show
        Justin Ross added a comment - Reviewed by Alan. Approved for 0.16.
        Hide
        Alan Conway added a comment -

        Strike the previous comment - the lock is for the source object not the object being constructed. The fix looks correct.

        Show
        Alan Conway added a comment - Strike the previous comment - the lock is for the source object not the object being constructed. The fix looks correct.
        Hide
        Alan Conway added a comment -

        Regarding the change in r1306434:

        The lock in the constructor is unnecessary, there can never be concurrent calls on a constructor.

        Otherwise it looks correct.

        Show
        Alan Conway added a comment - Regarding the change in r1306434: The lock in the constructor is unnecessary, there can never be concurrent calls on a constructor. Otherwise it looks correct.
        Ken Giusti made changes -
        Field Original Value New Value
        Priority Major [ 3 ] Blocker [ 1 ]
        Hide
        Ken Giusti added a comment -

        Appears to be a regression affecting 0.16.

        Show
        Ken Giusti added a comment - Appears to be a regression affecting 0.16.
        Ken Giusti created issue -

          People

          • Assignee:
            Ken Giusti
            Reporter:
            Ken Giusti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development