Qpid
  1. Qpid
  2. QPID-3888

make the SimpleQueueEntryList Iterator clean the list node structure during operation

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.15
    • Component/s: Java Broker
    • Labels:
      None

      Description

      Make the SimpleQueueEntryList Iterator clean the list node structure during operation by using the getNextValidEntry() method rather than getNextNode() method.

      This will result in the HouseKeeping thread performing cleanup similar to that of the scavenge() process, though far less aggressively. In concert with the message delivery processes now also using getNextValidEntry() this will allow the queue to be more self-cleaning, enabling us to work toward simply removing the explicit scavenge() calls which can hinder performance when using selectors and/or having vast numbers of messages on a queue.

        Activity

        Robbie Gemmell created issue -
        Robbie Gemmell made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Robbie Gemmell added a comment -

        Hi Rob,

        Can you review this change please? I havent actually gone so far as removing scavenge yet, I'd like to rework HouseKeeping a bit to make it much more frequent before doing that, this is just a little something that needs done before we could remove it.

        Robbie

        Show
        Robbie Gemmell added a comment - Hi Rob, Can you review this change please? I havent actually gone so far as removing scavenge yet, I'd like to rework HouseKeeping a bit to make it much more frequent before doing that, this is just a little something that needs done before we could remove it. Robbie
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Rob Godfrey [ rgodfrey ]
        Hide
        Rob Godfrey added a comment -

        looks good to me

        Show
        Rob Godfrey added a comment - looks good to me
        Rob Godfrey made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        2m 18s 1 Robbie Gemmell 06/Mar/12 23:40
        In Progress In Progress Reviewable Reviewable
        2m 1s 1 Robbie Gemmell 06/Mar/12 23:42
        Reviewable Reviewable Resolved Resolved
        8h 43m 1 Rob Godfrey 07/Mar/12 08:26
        Resolved Resolved Closed Closed
        1071d 11h 39m 1 Rob Godfrey 11/Feb/15 20:05

          People

          • Assignee:
            Rob Godfrey
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development