Qpid
  1. Qpid
  2. QPID-3831

the 0-10 Java client should use AcquireMode=PRE_ACQUIRED when using selectors on a Queue destination and server-side selectors are in use

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.14
    • Fix Version/s: 0.15
    • Component/s: Java Client
    • Labels:
      None

      Description

      When the 0-10 Java client is using selectors on a Queue destination and server-side selectors are available (i.e its connected to the Java broker), it should make use of AcquireMode=PRE_ACQUIRED instead of NOT_ACQUIRED in order to take full performance advantage of the broker having pre-evaluated the selector before sending it to the client. Currently, the client uses its awareness of the server-side selector only to stop itself evaluating the selector a second time (as the server already did it) when infact it should also use this awareness to request messages be PRE_ACQUIRED.

        Activity

        Hide
        Robbie Gemmell added a comment -

        Keith, could you review this change please?

        Thanks,
        Robbie

        Show
        Robbie Gemmell added a comment - Keith, could you review this change please? Thanks, Robbie
        Hide
        Keith Wall added a comment -

        No comments, changes look good.

        Show
        Keith Wall added a comment - No comments, changes look good.

          People

          • Assignee:
            Keith Wall
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development