Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-3823

ServerSession unblock(AMQQueue) can cause NPE when trying to remove a queue from _blockingQueues Map that is not present

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.15
    • 0.15
    • Broker-J
    • None

    Description

      When running multiple producers and a single consumer on a queue, the unblock code NPEs when trying to remove a queue entry, from the _blockingQueues Map, that is not present. This is due to the Map being given a Boolean keyed by Queue and in the case above the Map.remove() method returns null.

      The data structures used to hold the blocking queues and sessions used in SimpleAMQQueue and the AMQSessionModel implementations (ServerSession & AMQCHannel) should be changed from ConcurrentMaps to Sets - specifically ConcurrentSkipListSet. This will prevent the NPE from being possible.

      Attachments

        Activity

          People

            kwall Keith Wall
            macbean Andrew MacBean
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: