Qpid
  1. Qpid
  2. QPID-3820

ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.15
    • Fix Version/s: 0.15
    • Component/s: Java Broker, Java Tests
    • Labels:
      None

      Description

      On the 0-10 profiles, we see ProducerFlowControlTest#testSendTimeout occasionally fail with the following stack trace:

      org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout
      Failing for the past 1 build (Since Failed#47 )
      Took 10 sec.
      Error Message
      
      No timeout exception on sending
      
      Stacktrace
      
      junit.framework.AssertionFailedError: No timeout exception on sending
      	at org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout(ProducerFlowControlTest.java:344)
      	at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:237)
      	at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:138)
      
      

        Activity

        Keith Wall created issue -
        Keith Wall made changes -
        Field Original Value New Value
        Summary ProducerFlowControlTest test fails sprodically on 0-10 profiles ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles
        Affects Version/s 0.15 [ 12319043 ]
        Hide
        Keith Wall added a comment - - edited

        Whilst I have not been able to successfully reproduce the testSendTimeout issue reported above, I can say that the whole test suite looks very brittle: it relies heavily on Thread.sleep() in the hope that sufficient time will have passed to allow observations to be made (exception to arrive etc, messages delivery to be stopped) etc. The Thread.sleep() approach also means the testcase is very slow 120s..160s on my box. I've seen a couple of other PSFC tests fail during the course of the last few hours. It would be best if this suite were rewritten.

        Show
        Keith Wall added a comment - - edited Whilst I have not been able to successfully reproduce the testSendTimeout issue reported above, I can say that the whole test suite looks very brittle: it relies heavily on Thread.sleep() in the hope that sufficient time will have passed to allow observations to be made (exception to arrive etc, messages delivery to be stopped) etc. The Thread.sleep() approach also means the testcase is very slow 120s..160s on my box. I've seen a couple of other PSFC tests fail during the course of the last few hours. It would be best if this suite were rewritten.
        Keith Wall made changes -
        Assignee Keith Wall [ k-wall ]
        Keith Wall made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Keith Wall made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Keith Wall added a comment -

        Patch applied to resolve defect in testcase. Robbie, can you review the change please?

        Show
        Keith Wall added a comment - Patch applied to resolve defect in testcase. Robbie, can you review the change please?
        Keith Wall made changes -
        Assignee Keith Wall [ k-wall ] Robbie Gemmell [ gemmellr ]
        Hide
        Robbie Gemmell added a comment -

        Looks good to me.

        Show
        Robbie Gemmell added a comment - Looks good to me.
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Fix Version/s 0.15 [ 12319043 ]
        Resolution Fixed [ 1 ]
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        2d 1h 1m 1 Keith Wall 09/Feb/12 16:16
        In Progress In Progress Reviewable Reviewable
        21s 1 Keith Wall 09/Feb/12 16:17
        Reviewable Reviewable Resolved Resolved
        4d 22h 2m 1 Robbie Gemmell 14/Feb/12 14:19
        Resolved Resolved Closed Closed
        1093d 5h 46m 1 Rob Godfrey 11/Feb/15 20:06

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development