Qpid
  1. Qpid
  2. QPID-3815

0-10 connections produce duplicate connection open log messages

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.14
    • Fix Version/s: 0.15
    • Component/s: Java Broker
    • Labels:
      None

      Description

      0-10 connections produce duplicate connection open log messages.

      This is not caught by the logging test covering these message because it is incorrectly allowing for extra log messages to cover the case where we previously used to log both the unsuccessfull (unsupported) 0-10 attempt and the subsequent 0-9 open messages when running the 0-9 test profiles, but since the removal of mina the logging now only occurs on connections which succeed in agreeing a protocol version.

      The underlying cause of the issue is that we are setting the NetworkConnection onto the ProtocolEngine twice, with the 0-10 open logging being present in this area causing it to be emitted twice.

        Activity

        Robbie Gemmell created issue -
        Robbie Gemmell made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Robbie Gemmell added a comment -

        Keith, could you review this change please?

        Thanks,
        Robbie

        Show
        Robbie Gemmell added a comment - Keith, could you review this change please? Thanks, Robbie
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Keith Wall [ k-wall ]
        Hide
        Keith Wall added a comment -

        Changes look good to me.

        Show
        Keith Wall added a comment - Changes look good to me.
        Keith Wall made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        23h 13m 1 Robbie Gemmell 06/Feb/12 23:23
        In Progress In Progress Reviewable Reviewable
        4s 1 Robbie Gemmell 06/Feb/12 23:23
        Reviewable Reviewable Resolved Resolved
        10h 40m 1 Keith Wall 07/Feb/12 10:04
        Resolved Resolved Closed Closed
        1100d 10h 2m 1 Rob Godfrey 11/Feb/15 20:06

          People

          • Assignee:
            Keith Wall
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development