Qpid
  1. Qpid
  2. QPID-3790

Add a new method getQueueDepth(AMQDestionation, boolean) into AMQSession to allow syncing the session before sending QueueQuery command

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.15
    • Fix Version/s: 0.15
    • Component/s: Java Client
    • Labels:
      None

      Description

      The number of existing tests fails sporadically in DUPS_OK mode by relying on fact that method AMQSession.getQueueDepth(AMQDestionation) returns the correct result.

      In case of DUPS_OK, a message acknowledgment can be sent as part AMQSession.getQueueDepth(AMQDestionation) before sending QueueQuery command.
      Currently session does not sync between sending acknowledgments(MessageAccept) and QueueQuery commands.

      As result of it QueueQuery command results can be returned before MessageAccept is processed on the broker. In this case QueueQuery results might contain incorrect messageCount value.

        Activity

        Hide
        Robbie Gemmell added a comment -

        Patch applied.

        Show
        Robbie Gemmell added a comment - Patch applied.
        Hide
        Alex Rudyy added a comment -

        Robbie,

        I changed AMQSession_0_10Test which extends QpidTestCase now and uploaded a new patch

        Could you please commit it?

        Show
        Alex Rudyy added a comment - Robbie, I changed AMQSession_0_10Test which extends QpidTestCase now and uploaded a new patch Could you please commit it?
        Hide
        Robbie Gemmell added a comment -

        Change itself looks fine, but I would use QpidTestCase to tidy up the system property manipulation.

        Show
        Robbie Gemmell added a comment - Change itself looks fine, but I would use QpidTestCase to tidy up the system property manipulation.
        Hide
        Alex Rudyy added a comment -

        Robbie,

        Could you please review and commit the suggested enhancement?

        Show
        Alex Rudyy added a comment - Robbie, Could you please review and commit the suggested enhancement?
        Hide
        Alex Rudyy added a comment -

        Added a patch with an enhancement

        Show
        Alex Rudyy added a comment - Added a patch with an enhancement

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Alex Rudyy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development