Qpid
  1. Qpid
  2. QPID-3768

Test org.apache.qpid.server.queue.SortedQueueTest.testGetNextWithAck fails sporadically on CI

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.15
    • Fix Version/s: 0.15
    • Component/s: Java Tests
    • Labels:
      None

      Description

      test profile:java-mms-spawn.0-9-1

      Received message with unexpected sorted key value expected:<7> but was:<6>

      Stacktrace
      junit.framework.ComparisonFailure: Received message with unexpected sorted key value expected:<7> but was:<6>
      at org.apache.qpid.server.queue.SortedQueueTest.receiveAndValidateMessage(SortedQueueTest.java:352)
      at org.apache.qpid.server.queue.SortedQueueTest.testGetNextWithAck(SortedQueueTest.java:300)
      at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:240)
      at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:135)
      
      

        Activity

        Keith Wall created issue -
        Hide
        Keith Wall added a comment -

        This test occasionally fails because it assumes that as messages 7, 6 and 5 are sent in individual transactions (SortedQueueTest.java,295-297) they will be delivered immediately to the client and not be subject to sorting by the queue. This assumption is unsafe.

        When the test fails (SortedQueueTest.java, 300) messages 7 and 6 have resided momentarily together in the queue and therefore have been sorted. The test sees message 6 when it expects message 7.

        The test needs to be changed to avoid assuming that the assertion on line 300 will always see message 7 and could in fact see message 6 or even 5.

        Show
        Keith Wall added a comment - This test occasionally fails because it assumes that as messages 7, 6 and 5 are sent in individual transactions (SortedQueueTest.java,295-297) they will be delivered immediately to the client and not be subject to sorting by the queue. This assumption is unsafe. When the test fails (SortedQueueTest.java, 300) messages 7 and 6 have resided momentarily together in the queue and therefore have been sorted. The test sees message 6 when it expects message 7. The test needs to be changed to avoid assuming that the assertion on line 300 will always see message 7 and could in fact see message 6 or even 5.
        Keith Wall made changes -
        Field Original Value New Value
        Description test profile:java-mms-spawn.0-9-1

        Received message with unexpected sorted key value expected:<7> but was:<6>Stacktrace
        junit.framework.ComparisonFailure: Received message with unexpected sorted key value expected:<7> but was:<6>
        at org.apache.qpid.server.queue.SortedQueueTest.receiveAndValidateMessage(SortedQueueTest.java:352)
        at org.apache.qpid.server.queue.SortedQueueTest.testGetNextWithAck(SortedQueueTest.java:300)
        at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:240)
        at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:135)

        test profile:java-mms-spawn.0-9-1

        Received message with unexpected sorted key value expected:<7> but was:<6>

        {code}
        Stacktrace
        junit.framework.ComparisonFailure: Received message with unexpected sorted key value expected:<7> but was:<6>
        at org.apache.qpid.server.queue.SortedQueueTest.receiveAndValidateMessage(SortedQueueTest.java:352)
        at org.apache.qpid.server.queue.SortedQueueTest.testGetNextWithAck(SortedQueueTest.java:300)
        at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:240)
        at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:135)

        {code}
        Keith Wall made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Keith Wall made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Keith Wall added a comment -

        Patch applied.

        Show
        Keith Wall added a comment - Patch applied.
        Hide
        Alex Rudyy added a comment -

        The changes in tests look fine for me

        Show
        Alex Rudyy added a comment - The changes in tests look fine for me
        Keith Wall made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Fix Version/s 0.15 [ 12319043 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        15h 10m 1 Keith Wall 18/Jan/12 23:29
        In Progress In Progress Reviewable Reviewable
        14m 21s 1 Keith Wall 18/Jan/12 23:44
        Reviewable Reviewable Resolved Resolved
        14h 40m 1 Keith Wall 19/Jan/12 14:24

          People

          • Assignee:
            Keith Wall
            Reporter:
            Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development