Qpid
  1. Qpid
  2. QPID-3755

Concurrent queue bind on the same queue results in crash

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.14
    • Fix Version/s: 0.15
    • Component/s: C++ Broker
    • Labels:
      None

      Description

      Description of problem:
      While concurrently creating bindings to the same queue from multiple broker
      connections, the broker will periodically crash.

      How reproducible:
      Frequently

      Steps to Reproduce:
      1. Concurrently create bindings to the same queue

      Actual results:
      Qpid broker will crash

      Expected results:
      Qpid broker does not crash and bindings are created

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3483/
        -----------------------------------------------------------

        Review request for Gordon Sim and Kenneth Giusti.

        Summary
        -------

        Added locking to the QueueBindings class.

        This addresses bug qpid-3755.
        https://issues.apache.org/jira/browse/qpid-3755

        Diffs


        trunk/qpid/cpp/src/qpid/broker/QueueBindings.h 1231047
        trunk/qpid/cpp/src/qpid/broker/QueueBindings.cpp 1231047

        Diff: https://reviews.apache.org/r/3483/diff

        Testing
        -------

        Thanks,

        Ted

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3483/ ----------------------------------------------------------- Review request for Gordon Sim and Kenneth Giusti. Summary ------- Added locking to the QueueBindings class. This addresses bug qpid-3755. https://issues.apache.org/jira/browse/qpid-3755 Diffs trunk/qpid/cpp/src/qpid/broker/QueueBindings.h 1231047 trunk/qpid/cpp/src/qpid/broker/QueueBindings.cpp 1231047 Diff: https://reviews.apache.org/r/3483/diff Testing ------- Thanks, Ted
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3483/#review4352
        -----------------------------------------------------------

        Ship it!

        • Gordon

        On 2012-01-13 14:03:29, Ted Ross wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3483/

        -----------------------------------------------------------

        (Updated 2012-01-13 14:03:29)

        Review request for Gordon Sim and Kenneth Giusti.

        Summary

        -------

        Added locking to the QueueBindings class.

        This addresses bug qpid-3755.

        https://issues.apache.org/jira/browse/qpid-3755

        Diffs

        -----

        trunk/qpid/cpp/src/qpid/broker/QueueBindings.h 1231047

        trunk/qpid/cpp/src/qpid/broker/QueueBindings.cpp 1231047

        Diff: https://reviews.apache.org/r/3483/diff

        Testing

        -------

        Thanks,

        Ted

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3483/#review4352 ----------------------------------------------------------- Ship it! Gordon On 2012-01-13 14:03:29, Ted Ross wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3483/ ----------------------------------------------------------- (Updated 2012-01-13 14:03:29) Review request for Gordon Sim and Kenneth Giusti. Summary ------- Added locking to the QueueBindings class. This addresses bug qpid-3755. https://issues.apache.org/jira/browse/qpid-3755 Diffs ----- trunk/qpid/cpp/src/qpid/broker/QueueBindings.h 1231047 trunk/qpid/cpp/src/qpid/broker/QueueBindings.cpp 1231047 Diff: https://reviews.apache.org/r/3483/diff Testing ------- Thanks, Ted
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3483/#review4357
        -----------------------------------------------------------

        Ship it!

        • Kenneth

        On 2012-01-13 14:03:29, Ted Ross wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3483/

        -----------------------------------------------------------

        (Updated 2012-01-13 14:03:29)

        Review request for Gordon Sim and Kenneth Giusti.

        Summary

        -------

        Added locking to the QueueBindings class.

        This addresses bug qpid-3755.

        https://issues.apache.org/jira/browse/qpid-3755

        Diffs

        -----

        trunk/qpid/cpp/src/qpid/broker/QueueBindings.h 1231047

        trunk/qpid/cpp/src/qpid/broker/QueueBindings.cpp 1231047

        Diff: https://reviews.apache.org/r/3483/diff

        Testing

        -------

        Thanks,

        Ted

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3483/#review4357 ----------------------------------------------------------- Ship it! Kenneth On 2012-01-13 14:03:29, Ted Ross wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3483/ ----------------------------------------------------------- (Updated 2012-01-13 14:03:29) Review request for Gordon Sim and Kenneth Giusti. Summary ------- Added locking to the QueueBindings class. This addresses bug qpid-3755. https://issues.apache.org/jira/browse/qpid-3755 Diffs ----- trunk/qpid/cpp/src/qpid/broker/QueueBindings.h 1231047 trunk/qpid/cpp/src/qpid/broker/QueueBindings.cpp 1231047 Diff: https://reviews.apache.org/r/3483/diff Testing ------- Thanks, Ted

          People

          • Assignee:
            Ted Ross
            Reporter:
            Ted Ross
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development