Qpid
  1. Qpid
  2. QPID-3743

[Java Broker] Remove catching of Exception during metadata retrieval in BDB store

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.15
    • Component/s: Java Broker
    • Labels:
      None

      Description

      Occurred while using BDB store with more messages than could be held in RAM (1 million 1Kb messages in a 2Gb heap on a 64-bit VM).

      ########################################################################
      #

      1. Unhandled Exception java.lang.NullPointerException in Thread pool-3-thread-16
        #
      2. Exiting
        #
        ########################################################################
        java.lang.NullPointerException
        at org.apache.qpid.server.message.MessageTransferMessage.getExpiration(MessageTransferMessage.java:89)
        at org.apache.qpid.server.queue.QueueEntryImpl.expired(QueueEntryImpl.java:151)
        at org.apache.qpid.server.queue.SimpleAMQQueue.getNextAvailableEntry(SimpleAMQQueue.java:1846)
        at org.apache.qpid.server.queue.SimpleAMQQueue.attemptDelivery(SimpleAMQQueue.java:1781)
        at org.apache.qpid.server.queue.SimpleAMQQueue.processQueue(SimpleAMQQueue.java:1964)
        at org.apache.qpid.server.queue.QueueRunner.run(QueueRunner.java:77)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
        at java.lang.Thread.run(Thread.java:722)

        Activity

        Rob Godfrey created issue -
        Alex Rudyy made changes -
        Field Original Value New Value
        Assignee Alex Rudyy [ alex.rufous ]
        Alex Rudyy made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Alex Rudyy added a comment -

        Attached a patch removing try-catch block on loading message meta data from dbd store

        Show
        Alex Rudyy added a comment - Attached a patch removing try-catch block on loading message meta data from dbd store
        Alex Rudyy made changes -
        Robbie Gemmell made changes -
        Summary [Java Broker] Null pointer exception causing broker to abruptly terminate [Java Broker] Remove catching of Exception during metadata retrieval in BDB store
        Fix Version/s 0.15 [ 12319043 ]
        Hide
        Robbie Gemmell added a comment -

        Updated title to reflect new scope. It has not been possible to reproduce the NPE seen above, and Rob is unsure it was on a clean trunk following some changes to persistence etc. What is clear though is that the NPE should only be possible if an exception was caught and null returned, where really the exception should have been thrown. This JIRA will now be used to make that change.

        Show
        Robbie Gemmell added a comment - Updated title to reflect new scope. It has not been possible to reproduce the NPE seen above, and Rob is unsure it was on a clean trunk following some changes to persistence etc. What is clear though is that the NPE should only be possible if an exception was caught and null returned, where really the exception should have been thrown. This JIRA will now be used to make that change.
        Robbie Gemmell made changes -
        Priority Blocker [ 1 ] Critical [ 2 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Robbie Gemmell added a comment -

        Patch applied.

        Show
        Robbie Gemmell added a comment - Patch applied.
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Assignee Alex Rudyy [ alex.rufous ] Robbie Gemmell [ gemmellr ]
        Resolution Fixed [ 1 ]
        Rob Godfrey made changes -
        Component/s Java Broker BDB Store [ 12315809 ]
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        36d 20h 47m 1 Alex Rudyy 16/Feb/12 14:38
        In Progress In Progress Reviewable Reviewable
        21h 23m 1 Robbie Gemmell 17/Feb/12 12:02
        Reviewable Reviewable Resolved Resolved
        29s 1 Robbie Gemmell 17/Feb/12 12:02
        Resolved Resolved Closed Closed
        1090d 8h 3m 1 Rob Godfrey 11/Feb/15 20:06

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Rob Godfrey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development