Qpid
  1. Qpid
  2. QPID-3718

The Ruby bindings failed to properly handle uint8_t types.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.15
    • Component/s: Ruby Client
    • Labels:
      None

      Description

      Adds an entry to the SWIG Ruby definition that properly maps between uint8_t and Fixnum.

        Activity

        Darryl L. Pierce created issue -
        Darryl L. Pierce made changes -
        Field Original Value New Value
        Attachment 0001-Fixes-the-handling-of-uint8_t-in-the-Ruby-bindings.patch [ 12509305 ]
        Hide
        Ted Ross added a comment -

        The typemaps in swig_ruby_typemaps.i didn't include uint8_t or int8_t. Your patch simply tells swig to treat uint8_t the same as "unsigned char" which is arguably cleaner than adding an explicit set of typemaps for uint8_t. Perhaps we should do the same for all the

        {u}

        int

        {8,16,32,64}

        _t types.

        Show
        Ted Ross added a comment - The typemaps in swig_ruby_typemaps.i didn't include uint8_t or int8_t. Your patch simply tells swig to treat uint8_t the same as "unsigned char" which is arguably cleaner than adding an explicit set of typemaps for uint8_t. Perhaps we should do the same for all the {u} int {8,16,32,64} _t types.
        Darryl L. Pierce made changes -
        Comment [ Sure, I can repost a patch that does all such elements. ]
        Darryl L. Pierce made changes -
        Hide
        Darryl L. Pierce added a comment -

        This patch handles uint8_t and int8_t mappings for Ruby.

        Show
        Darryl L. Pierce added a comment - This patch handles uint8_t and int8_t mappings for Ruby.
        Darryl L. Pierce made changes -
        Darryl L. Pierce made changes -
        Comment [ Here's an updated patch that handles signed and unsinged ints 8-64 bits in size. ]
        Ted Ross made changes -
        Assignee Ted Ross [ tedross ]
        Ted Ross made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 0.15 [ 12319043 ]
        Resolution Fixed [ 1 ]
        Justin Ross made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1d 1h 2m 1 Ted Ross 04/Jan/12 16:24
        Resolved Resolved Closed Closed
        572d 2h 28m 1 Justin Ross 29/Jul/13 19:53

          People

          • Assignee:
            Ted Ross
            Reporter:
            Darryl L. Pierce
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development