Qpid
  1. Qpid
  2. QPID-3713

Remove redundant failover test from Java system test suite.

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.15
    • Component/s: Java Tests
    • Labels:
      None

      Description

      The Java test suite contains a number of failover tests that duplicate the new tests introduced by the recent failover work. This task is to remove redundant tests.

      The following tests/test cases have been identified:

      • QueueBrowserAutoAckTest#testFailover*. These tests were running against Java 0-9-1 profiles and excluded against Java/CPP 0-10. New test cases FailoverBehaviourTest#testTransactedQueueBrowserCloseWhileFailover/testClientAcknowledge test the same code paths.
      • AcknowledgeAfterFailoverOnMessageTest/AcknowledgeAfterFailoverTest. These tests were globally excluded (Excludes file). New tests FBT.testClientAcknowledgedSessionCloseAfterFailover/testTransactedSessionCloseAfterFailover/testAcknowledgeAfterFailoverForAsynchronousConsumer cover these scenarios.
      • MessageDisappearWithIOExceptionTest. Tests were added after a defect arising from Java Broker use of MINA. Test scenario covered by FBT.testRecoverAfterFailoverInAutoAcknowledgeMode.
      • FailoverBeforeConsumingRecoverTest. Test case seemed weak: merely caused a failover then repeated the same tests as its super (RecoverTest). FBT.testRecoverAfterFailover and testRecoverWithConsumedMessagesAfterFailover are superior replacements.
      • QuickAcking. Test exercised same code paths as FBT.testMessageProducingAndRollbackAfterFailover.
      • CloseAfterConnectionFailureTest duplicates FailoverMethodTest#testNoFailover. The testcase was actually excluded from all profiles.

        Activity

        Hide
        Robbie Gemmell added a comment -

        Looks good to me.

        P.S. thanks for beating me to this, its one of the things I was going to do at the end of the holidays, and so still wouldn't have been done yet due to the subsequent lack of electricity

        Show
        Robbie Gemmell added a comment - Looks good to me. P.S. thanks for beating me to this, its one of the things I was going to do at the end of the holidays, and so still wouldn't have been done yet due to the subsequent lack of electricity
        Hide
        Keith Wall added a comment -

        Hi Robbie, could you review this change please?

        Show
        Keith Wall added a comment - Hi Robbie, could you review this change please?

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development