Qpid
  1. Qpid
  2. QPID-3712

QpidBrokerTestCase#isExternalBroker uses incorrect logic to determine if testing with separate Broker process

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.15
    • Fix Version/s: 0.15
    • Component/s: Java Tests
    • Labels:
      None

      Description

      QpidBrokerTestCase#isExternalBroker allows system tests to determine if they are running with an external (that is, a separately spawned Broker process), rather than a (Java) Broker within the same VM as the junit test. Logic currently uses expression !_brokerType.equals("vm"), which is a hang-over from when we used to test using Mina in-VM protocol.

      This problem contributed to QPID-3566.

        Issue Links

          Activity

          Robbie Gemmell made changes -
          Status Ready To Review [ 10006 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Robbie Gemmell added a comment -

          Changes look good.

          I have raised QPID-3728 to cover the fact that many of the uses of this method are no longer necessary.

          Show
          Robbie Gemmell added a comment - Changes look good. I have raised QPID-3728 to cover the fact that many of the uses of this method are no longer necessary.
          Robbie Gemmell made changes -
          Link This issue is related to QPID-3728 [ QPID-3728 ]
          Keith Wall made changes -
          Summary QpidBrokerTestCase#isExternalBroker uses incorrect logic to determine if testing with separately Broker process QpidBrokerTestCase#isExternalBroker uses incorrect logic to determine if testing with separate Broker process
          Keith Wall made changes -
          Fix Version/s 0.15 [ 12319043 ]
          Keith Wall made changes -
          Link This issue is related to QPID-3566 [ QPID-3566 ]
          Keith Wall made changes -
          Assignee Keith Wall [ k-wall ] Robbie Gemmell [ gemmellr ]
          Hide
          Keith Wall added a comment -

          Hi Robbie, can you review this change please?

          Show
          Keith Wall added a comment - Hi Robbie, can you review this change please?
          Keith Wall made changes -
          Status In Progress [ 3 ] Ready To Review [ 10006 ]
          Keith Wall made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Keith Wall created issue -

            People

            • Assignee:
              Robbie Gemmell
              Reporter:
              Keith Wall
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development