Qpid
  1. Qpid
  2. QPID-3651

Improve the Qpid::Messaging::Sender APIs and documentation.

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.15
    • Component/s: None
    • Labels:
      None

      Activity

      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/2976/
      -----------------------------------------------------------

      (Updated 2011-12-14 13:26:28.786557)

      Review request for Andrew Stitcher, Gordon Sim and Ted Ross.

      Summary
      -------

      The main change is to the Sender.send API. It now takes an optional block that, if supplied, is invoked after the message is successfully sents.

      This patch set also updates the RDocs to help users more clearly understand how to use the class.

      This addresses bug QPID-3651.
      https://issues.apache.org/jira/browse/QPID-3651

      Diffs


      trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/sender.rb 1208094
      trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/session.rb 1208094
      trunk/qpid/cpp/bindings/qpid/ruby/test/test_sender.rb 1208094

      Diff: https://reviews.apache.org/r/2976/diff

      Testing
      -------

      All unit tests and examples work the same after this code was written.

      Thanks,

      Darryl

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2976/ ----------------------------------------------------------- (Updated 2011-12-14 13:26:28.786557) Review request for Andrew Stitcher, Gordon Sim and Ted Ross. Summary ------- The main change is to the Sender.send API. It now takes an optional block that, if supplied, is invoked after the message is successfully sents. This patch set also updates the RDocs to help users more clearly understand how to use the class. This addresses bug QPID-3651 . https://issues.apache.org/jira/browse/QPID-3651 Diffs trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/sender.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/session.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/test/test_sender.rb 1208094 Diff: https://reviews.apache.org/r/2976/diff Testing ------- All unit tests and examples work the same after this code was written. Thanks, Darryl
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/2976/
      -----------------------------------------------------------

      (Updated 2011-11-30 16:37:04.774946)

      Review request for Gordon Sim and Ted Ross.

      Summary
      -------

      The main change is to the Sender.send API. It now takes an optional block that, if supplied, is invoked after the message is successfully sents.

      This patch set also updates the RDocs to help users more clearly understand how to use the class.

      This addresses bug QPID-3651.
      https://issues.apache.org/jira/browse/QPID-3651

      Diffs


      trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/sender.rb 1208094
      trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/session.rb 1208094
      trunk/qpid/cpp/bindings/qpid/ruby/test/test_sender.rb 1208094

      Diff: https://reviews.apache.org/r/2976/diff

      Testing
      -------

      All unit tests and examples work the same after this code was written.

      Thanks,

      Darryl

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2976/ ----------------------------------------------------------- (Updated 2011-11-30 16:37:04.774946) Review request for Gordon Sim and Ted Ross. Summary ------- The main change is to the Sender.send API. It now takes an optional block that, if supplied, is invoked after the message is successfully sents. This patch set also updates the RDocs to help users more clearly understand how to use the class. This addresses bug QPID-3651 . https://issues.apache.org/jira/browse/QPID-3651 Diffs trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/sender.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/session.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/test/test_sender.rb 1208094 Diff: https://reviews.apache.org/r/2976/diff Testing ------- All unit tests and examples work the same after this code was written. Thanks, Darryl
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/2976/
      -----------------------------------------------------------

      Review request for Ted Ross.

      Summary
      -------

      The main change is to the Sender.send API. It now takes an optional block that, if supplied, is invoked after the message is successfully sents.

      This patch set also updates the RDocs to help users more clearly understand how to use the class.

      This addresses bug QPID-3651.
      https://issues.apache.org/jira/browse/QPID-3651

      Diffs


      trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/sender.rb 1208094
      trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/session.rb 1208094
      trunk/qpid/cpp/bindings/qpid/ruby/test/test_sender.rb 1208094

      Diff: https://reviews.apache.org/r/2976/diff

      Testing
      -------

      All unit tests and examples work the same after this code was written.

      Thanks,

      Darryl

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2976/ ----------------------------------------------------------- Review request for Ted Ross. Summary ------- The main change is to the Sender.send API. It now takes an optional block that, if supplied, is invoked after the message is successfully sents. This patch set also updates the RDocs to help users more clearly understand how to use the class. This addresses bug QPID-3651 . https://issues.apache.org/jira/browse/QPID-3651 Diffs trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/sender.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/session.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/test/test_sender.rb 1208094 Diff: https://reviews.apache.org/r/2976/diff Testing ------- All unit tests and examples work the same after this code was written. Thanks, Darryl

        People

        • Assignee:
          Ted Ross
          Reporter:
          Darryl L. Pierce
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development