Qpid
  1. Qpid
  2. QPID-3639

Refactored the APIs for Qpid::Messaging::Session and modified the documentation.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.15
    • Component/s: Ruby Client
    • Labels:
      None

      Description

      Several improvements to the Ruby code for a Session to make it more consistent as well as to fix excessive object creation.

      Also fixed the documentation so that the generated help files are more useful.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2978/
        -----------------------------------------------------------

        Review request for Gordon Sim and Ted Ross.

        Summary
        -------

        Cleans up and makes the APIs more Ruby-like. Added better RDoc documentation to the APIs.

        This addresses bug QPID-3639.
        https://issues.apache.org/jira/browse/QPID-3639

        Diffs


        trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/connection.rb 1208094
        trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/receiver.rb 1208094
        trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/sender.rb 1208094
        trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/session.rb 1208094
        trunk/qpid/cpp/bindings/qpid/ruby/test/test_receiver.rb 1208094
        trunk/qpid/cpp/bindings/qpid/ruby/test/test_sender.rb 1208094
        trunk/qpid/cpp/bindings/qpid/ruby/test/test_session.rb 1208094

        Diff: https://reviews.apache.org/r/2978/diff

        Testing
        -------

        Thanks,

        Darryl

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2978/ ----------------------------------------------------------- Review request for Gordon Sim and Ted Ross. Summary ------- Cleans up and makes the APIs more Ruby-like. Added better RDoc documentation to the APIs. This addresses bug QPID-3639 . https://issues.apache.org/jira/browse/QPID-3639 Diffs trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/connection.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/receiver.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/sender.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/session.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/test/test_receiver.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/test/test_sender.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/test/test_session.rb 1208094 Diff: https://reviews.apache.org/r/2978/diff Testing ------- Thanks, Darryl
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2978/
        -----------------------------------------------------------

        (Updated 2011-12-09 20:31:46.385562)

        Review request for Andrew Stitcher, Gordon Sim and Ted Ross.

        Changes
        -------

        Added a block to Session.next_receiver to optional process Receivers that way.

        Summary
        -------

        Cleans up and makes the APIs more Ruby-like. Added better RDoc documentation to the APIs.

        This addresses bug QPID-3639.
        https://issues.apache.org/jira/browse/QPID-3639

        Diffs (updated)


        trunk/qpid/cpp/bindings/qpid/ruby/test/test_receiver.rb 1208094
        trunk/qpid/cpp/bindings/qpid/ruby/test/test_sender.rb 1208094
        trunk/qpid/cpp/bindings/qpid/ruby/test/test_session.rb 1208094
        trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/connection.rb 1208094
        trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/receiver.rb 1208094
        trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/sender.rb 1208094
        trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/session.rb 1208094

        Diff: https://reviews.apache.org/r/2978/diff

        Testing
        -------

        Thanks,

        Darryl

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2978/ ----------------------------------------------------------- (Updated 2011-12-09 20:31:46.385562) Review request for Andrew Stitcher, Gordon Sim and Ted Ross. Changes ------- Added a block to Session.next_receiver to optional process Receivers that way. Summary ------- Cleans up and makes the APIs more Ruby-like. Added better RDoc documentation to the APIs. This addresses bug QPID-3639 . https://issues.apache.org/jira/browse/QPID-3639 Diffs (updated) trunk/qpid/cpp/bindings/qpid/ruby/test/test_receiver.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/test/test_sender.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/test/test_session.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/connection.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/receiver.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/sender.rb 1208094 trunk/qpid/cpp/bindings/qpid/ruby/lib/qpid/session.rb 1208094 Diff: https://reviews.apache.org/r/2978/diff Testing ------- Thanks, Darryl
        Hide
        Darryl L. Pierce added a comment -

        This patch incorporates all preceeding ones.

        Show
        Darryl L. Pierce added a comment - This patch incorporates all preceeding ones.

          People

          • Assignee:
            Ted Ross
            Reporter:
            Darryl L. Pierce
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development