[QPID-3635] AMQQConnectionTest incorrect assumes an order in which the tests are run

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.15
• Component/s: Java Tests
• Assignee: Robbie Gemmell
• Reporter: Robert Godfrey
• Created: 21/Nov/11 12:00
• Updated: 14/Mar/17 20:07
• Resolved: 17/Jan/12 10:22

Description

The AMQConnection test class makes assumptions about the order in which tests are run and is generally just horribly ill-conceived.

For example the test testTopicSessionCreateBrowser() depends upon the initialisation of the member variable _topicSession which is initialised in the test testCreateTopicSession(), and is only still valid since though the test creates new connections in every setUp, it does not tear them down at the end of each test.

Note also that if the creation of _topicSession and _queueSession are moved to setUp then the test testGetChannelID() will fail as it depends on no prior sessions existing and also on a defined policy of assigning channel numbers to sessions (really this test makes no sense at all).