Qpid
  1. Qpid
  2. QPID-3547

qpid-config currently doesn't display useful information about headers exchange bindings

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.10
    • Fix Version/s: 0.15
    • Component/s: Python Tools
    • Labels:
    • Environment:

      qpid-config python tool

      Description

      qpid-config doesn't display useful binding information for headers exchange bindings, for the headers exchange the binding key is really just a handle.

      The most basic fix would be to test for the presence of bind.arguments in the QueueListRecurse and ExchangeListRecurse methods and if present to display the bind.arguments.

      For example in QueueListRecurse:

      if bind.arguments:
      print " bind [%s] => %s %s" % (bind.bindingKey, ename, bind.arguments)
      else:
      print " bind [%s] => %s" % (bind.bindingKey, ename)

      and in ExchangeListRecurse:

      if bind.arguments:
      print " bind [%s] => %s %s" % (bind.bindingKey, qname, bind.arguments)
      else:
      print " bind [%s] => %s" % (bind.bindingKey, qname)

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3839/
        -----------------------------------------------------------

        Review request for Kenneth Giusti, Ted Ross and Nuno Santos.

        Summary
        -------

        So that for e.g. headers exchanges you can actually see what the bindings are.

        This addresses bug QPID-3547.
        https://issues.apache.org/jira/browse/QPID-3547

        Diffs


        /trunk/qpid/tools/src/py/qpid-config 1079726

        Diff: https://reviews.apache.org/r/3839/diff

        Testing
        -------

        Basic

        Thanks,

        Gordon

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3839/ ----------------------------------------------------------- Review request for Kenneth Giusti, Ted Ross and Nuno Santos. Summary ------- So that for e.g. headers exchanges you can actually see what the bindings are. This addresses bug QPID-3547 . https://issues.apache.org/jira/browse/QPID-3547 Diffs /trunk/qpid/tools/src/py/qpid-config 1079726 Diff: https://reviews.apache.org/r/3839/diff Testing ------- Basic Thanks, Gordon
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3839/#review5055
        -----------------------------------------------------------

        Ship it!

        This looks good. The only thing I might have done differently is to use "%r" instead of "%s" for the arguments. However, since the arguments are always of type "dict", both formats are treated the same so it's fine the way it is.

        • Ted

        On 2012-02-10 21:02:10, Gordon Sim wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3839/

        -----------------------------------------------------------

        (Updated 2012-02-10 21:02:10)

        Review request for Kenneth Giusti, Ted Ross and Nuno Santos.

        Summary

        -------

        So that for e.g. headers exchanges you can actually see what the bindings are.

        This addresses bug QPID-3547.

        https://issues.apache.org/jira/browse/QPID-3547

        Diffs

        -----

        /trunk/qpid/tools/src/py/qpid-config 1079726

        Diff: https://reviews.apache.org/r/3839/diff

        Testing

        -------

        Basic

        Thanks,

        Gordon

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3839/#review5055 ----------------------------------------------------------- Ship it! This looks good. The only thing I might have done differently is to use "%r" instead of "%s" for the arguments. However, since the arguments are always of type "dict", both formats are treated the same so it's fine the way it is. Ted On 2012-02-10 21:02:10, Gordon Sim wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3839/ ----------------------------------------------------------- (Updated 2012-02-10 21:02:10) Review request for Kenneth Giusti, Ted Ross and Nuno Santos. Summary ------- So that for e.g. headers exchanges you can actually see what the bindings are. This addresses bug QPID-3547 . https://issues.apache.org/jira/browse/QPID-3547 Diffs ----- /trunk/qpid/tools/src/py/qpid-config 1079726 Diff: https://reviews.apache.org/r/3839/diff Testing ------- Basic Thanks, Gordon

          People

          • Assignee:
            Gordon Sim
            Reporter:
            Fraser Adams
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development