Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-3525

On invoking Session#recover() in MessageListener the current message is acknowledged after being released in recover()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
    • Fix Version/s: 0.13
    • Component/s: Java Client
    • Labels:
      None

      Description

      On invoking of Session#recover() in MessageListener the current message is acknowledged after being released by recover()

        Activity

        Hide
        alex.rufous Alex Rudyy added a comment -

        Attached patch from Robbie Gemmell and me fixing the issue.

        Show
        alex.rufous Alex Rudyy added a comment - Attached patch from Robbie Gemmell and me fixing the issue.
        Hide
        alex.rufous Alex Rudyy added a comment -

        Robbie, could you please review and apply a patch fixing the issue?

        Show
        alex.rufous Alex Rudyy added a comment - Robbie, could you please review and apply a patch fixing the issue?
        Hide
        gemmellr Robbie Gemmell added a comment -

        Patch applied. This change also fixes a somewhat severe issues on the 0-8/9/9-1 protocol path caused by the changes in QPID-2471 which meant the client would not recover messages as requested, and instead could consume the resent messages during the recover operation. The existing tests which could show this was broken were however also disabled by the changes in QPID-2471.

        Show
        gemmellr Robbie Gemmell added a comment - Patch applied. This change also fixes a somewhat severe issues on the 0-8/9/9-1 protocol path caused by the changes in QPID-2471 which meant the client would not recover messages as requested, and instead could consume the resent messages during the recover operation. The existing tests which could show this was broken were however also disabled by the changes in QPID-2471 .

          People

          • Assignee:
            gemmellr Robbie Gemmell
            Reporter:
            alex.rufous Alex Rudyy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development