Qpid
  1. Qpid
  2. QPID-3449

0-10 code path hardcodes session timeout to 60 seconds.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.10, 0.11, 0.12
    • Fix Version/s: 0.13
    • Component/s: Java Broker, Java Client
    • Labels:
      None

      Description

      The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync). This value is 60,000ms.

      Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

        Activity

        Keith Wall created issue -
        Alex Rudyy made changes -
        Field Original Value New Value
        Assignee Robbie Gemmell [ gemmellr ] Alex Rudyy [ alex.rufous ]
        Alex Rudyy made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Alex Rudyy added a comment -

        Patch changes transport Session to use timeout value specified via JVM settings "qpid.sync_op_timeout" or "amqj.default_syncwrite_timeout.
        This patch enables tests SyncWaitTimeoutDelayTest and SyncWaitDelayTest

        Show
        Alex Rudyy added a comment - Patch changes transport Session to use timeout value specified via JVM settings "qpid.sync_op_timeout" or "amqj.default_syncwrite_timeout. This patch enables tests SyncWaitTimeoutDelayTest and SyncWaitDelayTest
        Alex Rudyy made changes -
        Attachment QPID-3449-adds-ability-to-override-the-session-timeout.patch [ 12493142 ]
        Alex Rudyy made changes -
        Status In Progress [ 3 ] Open [ 1 ]
        Alex Rudyy made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Alex Rudyy made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Alex Rudyy added a comment -

        Robbie, could you please review this patch?

        Show
        Alex Rudyy added a comment - Robbie, could you please review this patch?
        Alex Rudyy made changes -
        Assignee Alex Rudyy [ alex.rufous ] Robbie Gemmell [ gemmellr ]
        Hide
        Robbie Gemmell added a comment -

        Putting this back to Open status, as it builds on the QPID-3448 which needs reworked. Also, the attempt to closing at the TCP level upon timeout might not actually accomplish this as the close method used will try use the connection normally to negotiate closure; this in itself may also timeout.

        Show
        Robbie Gemmell added a comment - Putting this back to Open status, as it builds on the QPID-3448 which needs reworked. Also, the attempt to closing at the TCP level upon timeout might not actually accomplish this as the close method used will try use the connection normally to negotiate closure; this in itself may also timeout.
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Open [ 1 ]
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Alex Rudyy [ alex.rufous ]
        Alex Rudyy made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Alex Rudyy made changes -
        Attachment QPID-3449-adds-ability-to-override-the-session-timeout.patch [ 12493142 ]
        Alex Rudyy made changes -
        Attachment QPID-3449-adds-ability-to-override-the-session-timeout.patch [ 12494016 ]
        Alex Rudyy made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Alex Rudyy added a comment -

        Robbie, could you please review an updated version of patch?

        A newly introduced by previous patch SessionTimeoutException was removed.
        Also, connection closure was removed as well.

        SyncWaitTimeoutDelayTest and SyncWaitDelatTest were not enabled as SyncWaitTimeoutDelayTest requires more work.

        Show
        Alex Rudyy added a comment - Robbie, could you please review an updated version of patch? A newly introduced by previous patch SessionTimeoutException was removed. Also, connection closure was removed as well. SyncWaitTimeoutDelayTest and SyncWaitDelatTest were not enabled as SyncWaitTimeoutDelayTest requires more work.
        Alex Rudyy made changes -
        Assignee Alex Rudyy [ alex.rufous ] Robbie Gemmell [ gemmellr ]
        Alex Rudyy made changes -
        Attachment QPID-3449-adds-ability-to-override-the-session-timeout.patch [ 12494016 ]
        Hide
        Alex Rudyy added a comment -

        Attached a new patch from me and Robbie.

        Show
        Alex Rudyy added a comment - Attached a new patch from me and Robbie.
        Alex Rudyy made changes -
        Hide
        Robbie Gemmell added a comment -

        Patch applied.

        Show
        Robbie Gemmell added a comment - Patch applied.
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Fix Version/s 0.13 [ 12316854 ]
        Resolution Fixed [ 1 ]
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development