Qpid
  1. Qpid
  2. QPID-3420

Make C++ broker's help text use consistent kibibyte abbreviations

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.10
    • Fix Version/s: 0.13
    • Component/s: C++ Broker
    • Labels:
      None

      Description

      Currently, the qpidd C++ broker's help text uses KiB in some places and kiB in others. Would be nice it they were consistent.

       qpidd --help | grep -i '[kmt]i\?b'
        --num-jfiles N (8)            Default number of files for each journal
                                      of read pages (1 read page = 64kiB)
                                      KiB. Allowable values - powers of 2: 1, 2, 4,
        --tpl-num-jfiles N (8)        Number of files for transaction prepared list
                                      64kiB)
                                      list write page cache in KiB. Allowable values
        --cluster-size N (1)       Wait for N cluster members before allowing clients
      

      Personally, I prefer KiB, but anything consistent would be good.

        Activity

        Hide
        Paul Colby added a comment -

        Thanks!

        Show
        Paul Colby added a comment - Thanks!
        Hide
        Kim van der Riet added a comment -

        Thanks for the patch. Fixed on trunk r.4472.

        Show
        Kim van der Riet added a comment - Thanks for the patch. Fixed on trunk r.4472.
        Hide
        Paul Colby added a comment -

        I've reported this issue at https://bugzilla.redhat.com/show_bug.cgi?id=733168 since it's specific to the persistent message store (aka rhm_store).

        Show
        Paul Colby added a comment - I've reported this issue at https://bugzilla.redhat.com/show_bug.cgi?id=733168 since it's specific to the persistent message store (aka rhm_store ).
        Hide
        Paul Colby added a comment -

        I just realised that although those strings are printed by qpidd, they actually come from the persistent store plugin.

        Show
        Paul Colby added a comment - I just realised that although those strings are printed by qpidd , they actually come from the persistent store plugin.

          People

          • Assignee:
            Unassigned
            Reporter:
            Paul Colby
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development