[QPID-3389] Provide more descriptive error text when sasl config. file is malformed

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.10
• Fix Version/s: 0.29
• Component/s: C++ Broker
• Labels: features starter
• Assignee: Pavel Moravec
• Reporter: Pavel Moravec
• Created: 04/Aug/11 10:51
• Updated: 26/Sep/14 15:42
• Resolved: 15/Jun/14 12:05

Description

When /etc/sasl2/qpidd.conf is un-parsable, then qpidd halts with very generic error. Based on the error text, it is unable to identify the source of the problem (the config file).

Replication scenario:
1) have in /etc/sasl2/qpidd.conf line:

mech_list:

(alternatively, have there line "mech_list plain" i.e. without colon)
2) Start qpidd process. It halts with tail trace log:
2011-08-04 12:48:29 debug Management object (V1) added: org.apache.qpid.broker:exchange:
2011-08-04 12:48:29 info Most recent persistence id found: 0x0
2011-08-04 12:48:29 debug Management object (V1) added: org.apache.qpid.broker:exchange:amq.direct
2011-08-04 12:48:29 debug Management object (V1) added: org.apache.qpid.broker:exchange:amq.topic
2011-08-04 12:48:29 debug Management object (V1) added: org.apache.qpid.broker:exchange:amq.fanout
2011-08-04 12:48:29 debug Management object (V1) added: org.apache.qpid.broker:exchange:amq.match
2011-08-04 12:48:29 debug Management object (V1) added: org.apache.qpid.broker:exchange:qpid.management
2011-08-04 12:48:29 debug Management object (V1) added: org.apache.qpid.broker:exchange:qmf.default.topic
2011-08-04 12:48:29 debug Management object (V1) added: org.apache.qpid.broker:exchange:qmf.default.direct
2011-08-04 12:48:29 debug Exception constructed: generic failure
2011-08-04 12:48:29 trace Management object marked deleted: org.apache.qpid.broker:exchange:amq.topic
2011-08-04 12:48:29 trace Management object marked deleted: org.apache.qpid.broker:exchange:amq.match
2011-08-04 12:48:29 trace Management object marked deleted: org.apache.qpid.broker:exchange:amq.fanout
2011-08-04 12:48:29 trace Management object marked deleted: org.apache.qpid.broker:exchange:
2011-08-04 12:48:29 debug Journal "TplStore": Destroyed
2011-08-04 12:48:29 trace Management object marked deleted: org.apache.qpid.broker:exchange:amq.direct
2011-08-04 12:48:29 trace Management object marked deleted: org.apache.qpid.broker:exchange:qpid.management
2011-08-04 12:48:29 trace Management object marked deleted: org.apache.qpid.broker:exchange:qmf.default.topic
2011-08-04 12:48:29 trace Management object marked deleted: org.apache.qpid.broker:exchange:qmf.default.direct
2011-08-04 12:48:29 critical Unexpected error: generic failure

3) The only relevant lines are with text "Unexpected error: generic failure".

Expected results:
Have a log entry similar to having a typo in /etc/qpidd.conf, where qpidd generates:
2011-08-04 12:39:53 debug Exception constructed: Error in configuration file /etc/qpidd.conf: no value given in 'auth='

(any log pointing to the sasl config file will be sufficient, as particular parsing of the file is (supposedly) performed by SASL library and not by qpid)