Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-3368

Check for dirty session after failover during commit() not in the correct place

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 0.10
    • Fix Version/s: None
    • Component/s: JMS AMQP 0-x
    • Labels:

      Description

      When a session is committed after failover using the session.commit() call, it incorrectly throws a RuntimeException (SessionException). It should throw a JMSException instead so that the client can recover.

      org.apache.qpid.client.AMQSession has a check for failover in its commit method, but this method is overridden in org.apache.qpid.client.AMQSession_0_10 and the latter does not have the failover check. As a result, the check is never used. I have attached a patch that reworks the code a bit to allow org.apache.qpid.client.AMQSession_0_10 to use the failover check during commit.

        Attachments

        1. qpid-java-check-failover.patch
          3 kB
          Siddhesh Poyarekar
        2. TxFailover.java
          2 kB
          Siddhesh Poyarekar

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              siddhesh Siddhesh Poyarekar
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: