Qpid
  1. Qpid
  2. QPID-3363

broker allows unbind on default exchange

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.10, 0.12
    • Fix Version/s: 0.13
    • Component/s: None
    • Labels:
      None

      Description

      Rule 'default-access' states "The default exchange MUST NOT be accessible to the client except by specifying an empty exchange name in a content publish command (such as message.transfer). That is, the server must not let clients explicitly bind, unbind, delete, or make any other reference to this exchange."

      However qpid-config unbind "" my-queue my-queue will delete the binding preventing the queue from being directly accessed.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1403/#review1341
        -----------------------------------------------------------

        Ship it!

        • Alan

        On 2011-08-09 11:34:40, Gordon Sim wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/1403/

        -----------------------------------------------------------

        (Updated 2011-08-09 11:34:40)

        Review request for Alan Conway and Kim van der Riet.

        Summary

        -------

        Error is now signalled as required by specification. The default exchange bindings are not explicitly replicated to cluster members; this was redundant anyway (as the bindings are established on creation of the queues in question) and now would cause errors.

        This addresses bug QPID-3363.

        https://issues.apache.org/jira/browse/QPID-3363

        Diffs

        -----

        /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1155286

        /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1155286

        /trunk/qpid/cpp/src/tests/federation_sys.py 1155286

        /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/exchange.py 1155286

        Diff: https://reviews.apache.org/r/1403/diff

        Testing

        -------

        New tests added. The federation_sys tests used the default exchange in an illegal manner and this tests replaces it with amq.direct (a general purpose, preconfigured exchange that seems more appropriate to the use case). Make check passes.

        Thanks,

        Gordon

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1403/#review1341 ----------------------------------------------------------- Ship it! Alan On 2011-08-09 11:34:40, Gordon Sim wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1403/ ----------------------------------------------------------- (Updated 2011-08-09 11:34:40) Review request for Alan Conway and Kim van der Riet. Summary ------- Error is now signalled as required by specification. The default exchange bindings are not explicitly replicated to cluster members; this was redundant anyway (as the bindings are established on creation of the queues in question) and now would cause errors. This addresses bug QPID-3363 . https://issues.apache.org/jira/browse/QPID-3363 Diffs ----- /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1155286 /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1155286 /trunk/qpid/cpp/src/tests/federation_sys.py 1155286 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/exchange.py 1155286 Diff: https://reviews.apache.org/r/1403/diff Testing ------- New tests added. The federation_sys tests used the default exchange in an illegal manner and this tests replaces it with amq.direct (a general purpose, preconfigured exchange that seems more appropriate to the use case). Make check passes. Thanks, Gordon
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1403/
        -----------------------------------------------------------

        (Updated 2011-08-09 11:34:40.107450)

        Review request for Alan Conway and Kim van der Riet.

        Changes
        -------

        Added new tests to the patch for review.

        Summary
        -------

        Error is now signalled as required by specification. The default exchange bindings are not explicitly replicated to cluster members; this was redundant anyway (as the bindings are established on creation of the queues in question) and now would cause errors.

        This addresses bug QPID-3363.
        https://issues.apache.org/jira/browse/QPID-3363

        Diffs (updated)


        /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1155286
        /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1155286
        /trunk/qpid/cpp/src/tests/federation_sys.py 1155286
        /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/exchange.py 1155286

        Diff: https://reviews.apache.org/r/1403/diff

        Testing
        -------

        New tests added. The federation_sys tests used the default exchange in an illegal manner and this tests replaces it with amq.direct (a general purpose, preconfigured exchange that seems more appropriate to the use case). Make check passes.

        Thanks,

        Gordon

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1403/ ----------------------------------------------------------- (Updated 2011-08-09 11:34:40.107450) Review request for Alan Conway and Kim van der Riet. Changes ------- Added new tests to the patch for review. Summary ------- Error is now signalled as required by specification. The default exchange bindings are not explicitly replicated to cluster members; this was redundant anyway (as the bindings are established on creation of the queues in question) and now would cause errors. This addresses bug QPID-3363 . https://issues.apache.org/jira/browse/QPID-3363 Diffs (updated) /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1155286 /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1155286 /trunk/qpid/cpp/src/tests/federation_sys.py 1155286 /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/exchange.py 1155286 Diff: https://reviews.apache.org/r/1403/diff Testing ------- New tests added. The federation_sys tests used the default exchange in an illegal manner and this tests replaces it with amq.direct (a general purpose, preconfigured exchange that seems more appropriate to the use case). Make check passes. Thanks, Gordon
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1403/
        -----------------------------------------------------------

        Review request for Alan Conway and Kim van der Riet.

        Summary
        -------

        Error is now signalled as required by specification. The default exchange bindings are not explicitly replicated to cluster members; this was redundant anyway (as the bindings are established on creation of the queues in question) and now would cause errors.

        This addresses bug QPID-3363.
        https://issues.apache.org/jira/browse/QPID-3363

        Diffs


        /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1155286
        /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1155286
        /trunk/qpid/cpp/src/tests/federation_sys.py 1155286

        Diff: https://reviews.apache.org/r/1403/diff

        Testing
        -------

        New tests added. The federation_sys tests used the default exchange in an illegal manner and this tests replaces it with amq.direct (a general purpose, preconfigured exchange that seems more appropriate to the use case). Make check passes.

        Thanks,

        Gordon

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1403/ ----------------------------------------------------------- Review request for Alan Conway and Kim van der Riet. Summary ------- Error is now signalled as required by specification. The default exchange bindings are not explicitly replicated to cluster members; this was redundant anyway (as the bindings are established on creation of the queues in question) and now would cause errors. This addresses bug QPID-3363 . https://issues.apache.org/jira/browse/QPID-3363 Diffs /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1155286 /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1155286 /trunk/qpid/cpp/src/tests/federation_sys.py 1155286 Diff: https://reviews.apache.org/r/1403/diff Testing ------- New tests added. The federation_sys tests used the default exchange in an illegal manner and this tests replaces it with amq.direct (a general purpose, preconfigured exchange that seems more appropriate to the use case). Make check passes. Thanks, Gordon

          People

          • Assignee:
            Gordon Sim
            Reporter:
            Gordon Sim
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development