Qpid
  1. Qpid
  2. QPID-3338

qpidxarm CMake target is missing in 0-12

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.12
    • Fix Version/s: 0.12
    • Component/s: C++ Broker, C++ Client
    • Labels:
      None
    • Environment:

      Windows with Microsoft compilers (as opposed to mingw)

      Description

      cpp/src/CMakeLists.txt was altered for mingw builds in QPID-2905 (r1104662).

      The qpidxarm target builds the XA distributed transaction resource manager for use with the Microsoft distributed trasanction coordinator. It was targeted for Windows builds only, using the CMake variable "WIN32".

      This variable was changed to "_MSC_VER" for QPID-2905, presumably to indicate that the build target should only apply to builds using the Microsoft compiler, and not mingw. Unfortunately "_MSC_VER" is not a recognized CMAKE variable and the qpidxarm target is never generated.

      The CMake documentation indicates the the variable "MSVC" should be used to indicate The Microsoft compiler compared to mingw.

      1. jira-3338.patch
        0.7 kB
        Cliff Jansen

        Activity

        Cliff Jansen created issue -
        Cliff Jansen made changes -
        Field Original Value New Value
        Attachment jira-3338.patch [ 12485544 ]
        Cliff Jansen made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Justin Ross made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Cliff Jansen
            Reporter:
            Cliff Jansen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development