Qpid
  1. Qpid
  2. QPID-3338

qpidxarm CMake target is missing in 0-12

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.12
    • Fix Version/s: 0.12
    • Component/s: C++ Broker, C++ Client
    • Labels:
      None
    • Environment:

      Windows with Microsoft compilers (as opposed to mingw)

      Description

      cpp/src/CMakeLists.txt was altered for mingw builds in QPID-2905 (r1104662).

      The qpidxarm target builds the XA distributed transaction resource manager for use with the Microsoft distributed trasanction coordinator. It was targeted for Windows builds only, using the CMake variable "WIN32".

      This variable was changed to "_MSC_VER" for QPID-2905, presumably to indicate that the build target should only apply to builds using the Microsoft compiler, and not mingw. Unfortunately "_MSC_VER" is not a recognized CMAKE variable and the qpidxarm target is never generated.

      The CMake documentation indicates the the variable "MSVC" should be used to indicate The Microsoft compiler compared to mingw.

      1. jira-3338.patch
        0.7 kB
        Cliff Jansen

        Activity

        Hide
        Cliff Jansen added a comment -

        This patch applies the MSVC variable and works properly on my Windows box using Visual studio 9. I do not have a mingw setup and would appreciate if someone who does could apply the patch and verify that the patch has no unwanted side effects for them.

        Thanks.

        Show
        Cliff Jansen added a comment - This patch applies the MSVC variable and works properly on my Windows box using Visual studio 9. I do not have a mingw setup and would appreciate if someone who does could apply the patch and verify that the patch has no unwanted side effects for them. Thanks.
        Hide
        Cliff Jansen added a comment -

        The patch tests fine on Fedora to generate makefiles via cmake

        Show
        Cliff Jansen added a comment - The patch tests fine on Fedora to generate makefiles via cmake
        Hide
        Justin Ross added a comment -

        Reviewed by Chuck Rolke on the dev list. Approved for 0.12.

        Show
        Justin Ross added a comment - Reviewed by Chuck Rolke on the dev list. Approved for 0.12.
        Hide
        Cliff Jansen added a comment -

        updated trunk: r1145883

        updated 0.12 branch: r1145886

        Show
        Cliff Jansen added a comment - updated trunk: r1145883 updated 0.12 branch: r1145886

          People

          • Assignee:
            Cliff Jansen
            Reporter:
            Cliff Jansen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development