Qpid
  1. Qpid
  2. QPID-3335

Remove duplicate and buggy type conversion code from Management Agent.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.12
    • Fix Version/s: 0.13
    • Component/s: C++ Broker
    • Labels:
      None

      Description

      The broker's management agent exports a FieldTable to Variant Map translation API. This duplicates the translation code from the common library (Codecs.h), and the version in the management agent is stale and buggy. Remove the duplication and have the management agent use the common code.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/988/
        -----------------------------------------------------------

        Review request for Gordon Sim, Kim van der Riet and Ted Ross.

        Summary
        -------

        Removes some old code that duplicates type conversions that are available in the common library.

        This addresses bug qpid-3335.
        https://issues.apache.org/jira/browse/qpid-3335

        Diffs


        /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1141932
        /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1141932

        Diff: https://reviews.apache.org/r/988/diff

        Testing
        -------

        unit.

        Thanks,

        Kenneth

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/988/ ----------------------------------------------------------- Review request for Gordon Sim, Kim van der Riet and Ted Ross. Summary ------- Removes some old code that duplicates type conversions that are available in the common library. This addresses bug qpid-3335. https://issues.apache.org/jira/browse/qpid-3335 Diffs /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1141932 /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1141932 Diff: https://reviews.apache.org/r/988/diff Testing ------- unit. Thanks, Kenneth
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/988/#review952
        -----------------------------------------------------------

        Ship it!

        • Gordon

        On 2011-07-01 13:58:26, Kenneth Giusti wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/988/

        -----------------------------------------------------------

        (Updated 2011-07-01 13:58:26)

        Review request for Gordon Sim, Kim van der Riet and Ted Ross.

        Summary

        -------

        Removes some old code that duplicates type conversions that are available in the common library.

        This addresses bug qpid-3335.

        https://issues.apache.org/jira/browse/qpid-3335

        Diffs

        -----

        /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1141932

        /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1141932

        Diff: https://reviews.apache.org/r/988/diff

        Testing

        -------

        unit.

        Thanks,

        Kenneth

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/988/#review952 ----------------------------------------------------------- Ship it! Gordon On 2011-07-01 13:58:26, Kenneth Giusti wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/988/ ----------------------------------------------------------- (Updated 2011-07-01 13:58:26) Review request for Gordon Sim, Kim van der Riet and Ted Ross. Summary ------- Removes some old code that duplicates type conversions that are available in the common library. This addresses bug qpid-3335. https://issues.apache.org/jira/browse/qpid-3335 Diffs ----- /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1141932 /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1141932 Diff: https://reviews.apache.org/r/988/diff Testing ------- unit. Thanks, Kenneth

          People

          • Assignee:
            Ken Giusti
            Reporter:
            Ken Giusti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development