Qpid
  1. Qpid
  2. QPID-3293

restore ability to set client connection send/receive buffer sizes

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.14
    • Fix Version/s: 0.15
    • Component/s: Java Client
    • Labels:
      None

      Description

      NOTE: original description below, see comments for updated scope mentioned in the title.

      In org.apache.qpid.configuration.ClientProperties, both READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value ("qpid.read.buffer.limit"). Presumably WRITE_BUFFER_LIMIT_PROP_NAME should be something like "qpid.write.buffer.limit", right?

        Activity

        Hide
        Keith Wall added a comment -

        Changes look good to me.

        Show
        Keith Wall added a comment - Changes look good to me.
        Hide
        Robbie Gemmell added a comment -

        Keith, could you review this please?

        Thanks,
        Robbie

        Show
        Robbie Gemmell added a comment - Keith, could you review this please? Thanks, Robbie
        Hide
        Robbie Gemmell added a comment -

        The properties mentioned in the original description were used for the 0-8/0-9 client and Java broker to control the ProtectIO functionality they had. That functionality was Mina specific, and was removed very shortly after this JIRA was raised. Our use of Mina followed not long after.

        The properties Rajith referred to that were used in IoTransport were inadvertantly removed during the IO layer update that lead on to the eventual removal of Mina.

        New properties should be added (not those used for ProtectIO) to allow controlling the buffer sizes, and support for the legacy properties restored for anyone upgrading.

        Show
        Robbie Gemmell added a comment - The properties mentioned in the original description were used for the 0-8/0-9 client and Java broker to control the ProtectIO functionality they had. That functionality was Mina specific, and was removed very shortly after this JIRA was raised. Our use of Mina followed not long after. The properties Rajith referred to that were used in IoTransport were inadvertantly removed during the IO layer update that lead on to the eventual removal of Mina. New properties should be added (not those used for ProtectIO) to allow controlling the buffer sizes, and support for the legacy properties restored for anyone upgrading.
        Hide
        Rajith Attapattu added a comment -

        Andy,

        The IoTransport class used the property names directly instead of the constants from the above class.
        The new ConnectionSettings class which sets the read and write buffer is not using property names either and they are not configurable as well.
        I have some unfinished work for the java client configuration and will fix the above as part of it.

        Rajith

        Show
        Rajith Attapattu added a comment - Andy, The IoTransport class used the property names directly instead of the constants from the above class. The new ConnectionSettings class which sets the read and write buffer is not using property names either and they are not configurable as well. I have some unfinished work for the java client configuration and will fix the above as part of it. Rajith

          People

          • Assignee:
            Keith Wall
            Reporter:
            Andy Goldstein
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development