Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10
    • Fix Version/s: 0.11
    • Component/s: Java Client
    • Labels:
      None

      Description

      AMQCallbackHandler is initialised with an AMQProtocolSession. The current concrete implementations of AMQCallbackHandler require only information encapsulated by the ConnectionUrl interface in order to perform their function.

      AMQCallbackHandler will be refactored to be initialised with ConnectionUrl. This will simplify unit testing of new concrete implementations and reduce code complexity by improving information hiding.

        Activity

        Keith Wall created issue -
        Hide
        Keith Wall added a comment -

        AMQCallbackHandler improvements.
        Refactor AMQCallbackHandler to accept ConnectionURL in place of AMQProtocolSession (improved information hiding, ease ability to write good unit tests). Remove unused protected constructor from AMQConnectiona and MockAMQConnection.

        Show
        Keith Wall added a comment - AMQCallbackHandler improvements. Refactor AMQCallbackHandler to accept ConnectionURL in place of AMQProtocolSession (improved information hiding, ease ability to write good unit tests). Remove unused protected constructor from AMQConnectiona and MockAMQConnection.
        Keith Wall made changes -
        Field Original Value New Value
        Attachment 0001-QPID-3277-AMQCallbackHandler-improvements.-Refactor-.patch [ 12480418 ]
        Keith Wall made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Keith Wall made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Keith Wall added a comment -

        Hi Robbie - would you mind taking a look at this patch?

        Show
        Keith Wall added a comment - Hi Robbie - would you mind taking a look at this patch?
        Keith Wall made changes -
        Assignee Keith Wall [ k-wall ] Robbie Gemmell [ gemmellr ]
        Hide
        Robbie Gemmell added a comment -

        Patch applied

        Show
        Robbie Gemmell added a comment - Patch applied
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Fix Version/s 0.11 [ 12316272 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development