Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10
    • Fix Version/s: 0.11
    • Component/s: JMS AMQP 0-x
    • Labels:
      None

      Description

      AMQCallbackHandler is initialised with an AMQProtocolSession. The current concrete implementations of AMQCallbackHandler require only information encapsulated by the ConnectionUrl interface in order to perform their function.

      AMQCallbackHandler will be refactored to be initialised with ConnectionUrl. This will simplify unit testing of new concrete implementations and reduce code complexity by improving information hiding.

        Activity

        Hide
        gemmellr Robbie Gemmell added a comment -

        Patch applied

        Show
        gemmellr Robbie Gemmell added a comment - Patch applied
        Hide
        k-wall Keith Wall added a comment -

        Hi Robbie - would you mind taking a look at this patch?

        Show
        k-wall Keith Wall added a comment - Hi Robbie - would you mind taking a look at this patch?
        Hide
        k-wall Keith Wall added a comment -

        AMQCallbackHandler improvements.
        Refactor AMQCallbackHandler to accept ConnectionURL in place of AMQProtocolSession (improved information hiding, ease ability to write good unit tests). Remove unused protected constructor from AMQConnectiona and MockAMQConnection.

        Show
        k-wall Keith Wall added a comment - AMQCallbackHandler improvements. Refactor AMQCallbackHandler to accept ConnectionURL in place of AMQProtocolSession (improved information hiding, ease ability to write good unit tests). Remove unused protected constructor from AMQConnectiona and MockAMQConnection.

          People

          • Assignee:
            gemmellr Robbie Gemmell
            Reporter:
            k-wall Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development