Qpid
  1. Qpid
  2. QPID-3267

Java broker authentication does not work on JRE's other than Sun's

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
    • Fix Version/s: 0.13
    • Component/s: Java Broker
    • Labels:
      None

      Description

      This is due to use of com.sun.security.auth.UserPrincipal in ServerSession which is sun-specific.

      1. QPID-3267.patch
        2 kB
        Danushka Menikkumbura

        Issue Links

          Activity

          Danushka Menikkumbura created issue -
          Danushka Menikkumbura made changes -
          Field Original Value New Value
          Attachment QPID-3267.patch [ 12479809 ]
          Hide
          Danushka Menikkumbura added a comment -

          As I understand we need to have an internal implementation of UserPrincipal to fix this issue. Please review and apply the attached patch.

          Thanks,
          Danushka

          Show
          Danushka Menikkumbura added a comment - As I understand we need to have an internal implementation of UserPrincipal to fix this issue. Please review and apply the attached patch. Thanks, Danushka
          Hide
          Keith Wall added a comment -

          Hi Danushka

          I agree with the intention of the patch, but is there a reason why you didn't use the existing class UsernamePrincipal (org.apache.qpid.server.auth.sasl) rather than introduce a new?

          cheers Keith.

          Show
          Keith Wall added a comment - Hi Danushka I agree with the intention of the patch, but is there a reason why you didn't use the existing class UsernamePrincipal (org.apache.qpid.server.auth.sasl) rather than introduce a new? cheers Keith.
          Robbie Gemmell made changes -
          Assignee Robbie Gemmell [ gemmellr ]
          Hide
          Robbie Gemmell added a comment -

          I echo Keith's comments about the unecessary duplication, and would add that there was also no unit test for the new class in the patch (although that was also true of the existing class at the time, but I see Keith added tests in subsequent work he did).

          Given that the majority of the attached patch is unecessary due to the above, and it looks like the patch in QPID-3310 removes the use of com.sun.security.auth.UserPrincipal in ServerSession anyway whilst to use Subjects, I am just going to incorporate this issue into QPID-3310.

          Show
          Robbie Gemmell added a comment - I echo Keith's comments about the unecessary duplication, and would add that there was also no unit test for the new class in the patch (although that was also true of the existing class at the time, but I see Keith added tests in subsequent work he did). Given that the majority of the attached patch is unecessary due to the above, and it looks like the patch in QPID-3310 removes the use of com.sun.security.auth.UserPrincipal in ServerSession anyway whilst to use Subjects, I am just going to incorporate this issue into QPID-3310 .
          Robbie Gemmell made changes -
          Link This issue is part of QPID-3310 [ QPID-3310 ]
          Robbie Gemmell made changes -
          Assignee Robbie Gemmell [ gemmellr ] Keith Wall [ k-wall ]
          Robbie Gemmell made changes -
          Assignee Keith Wall [ k-wall ] Robbie Gemmell [ gemmellr ]
          Robbie Gemmell made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Robbie Gemmell made changes -
          Status In Progress [ 3 ] Ready To Review [ 10006 ]
          Hide
          Robbie Gemmell added a comment -

          Hi Danushka,

          With the patch for QPID-3310 now applied, this issue should hopefully be resolved, so I've pushed this JIRA to Ready To Review as a result, Can you check the updated code meets your need and close this out if it does?

          Thanks,
          Robbie

          Show
          Robbie Gemmell added a comment - Hi Danushka, With the patch for QPID-3310 now applied, this issue should hopefully be resolved, so I've pushed this JIRA to Ready To Review as a result, Can you check the updated code meets your need and close this out if it does? Thanks, Robbie
          Robbie Gemmell made changes -
          Fix Version/s 0.13 [ 12316854 ]
          Affects Version/s 0.10 [ 12316273 ]
          Affects Version/s 0.9 [ 12315382 ]
          Affects Version/s 0.8 [ 12315477 ]
          Affects Version/s 0.7 [ 12314455 ]
          Affects Version/s 0.6 [ 12313728 ]
          Affects Version/s 0.11 [ 12316272 ]
          Affects Version/s 0.12 [ 12316848 ]
          Component/s Java Broker [ 12311388 ]
          Robbie Gemmell made changes -
          Fix Version/s JIRA Cleanup [ 12317862 ]
          Fix Version/s 0.13 [ 12316854 ]
          Assignee Robbie Gemmell [ gemmellr ]
          Hide
          Robbie Gemmell added a comment -

          Review-OK'ing issue as part of JIRA cleanup. Issue could be resolved, but may not be: see QPID-3469 for further details.

          Show
          Robbie Gemmell added a comment - Review-OK'ing issue as part of JIRA cleanup. Issue could be resolved, but may not be: see QPID-3469 for further details.
          Robbie Gemmell made changes -
          Status Ready To Review [ 10006 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Robbie Gemmell made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Robbie Gemmell added a comment -

          Updating this since it looks to be complete, marking for 0.13 instead of JIRA cleanup from above comment/action.

          Show
          Robbie Gemmell added a comment - Updating this since it looks to be complete, marking for 0.13 instead of JIRA cleanup from above comment/action.
          Robbie Gemmell made changes -
          Fix Version/s 0.13 [ 12316854 ]
          Fix Version/s JIRA Cleanup [ 12317862 ]
          Robbie Gemmell made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Robbie Gemmell made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Rob Godfrey made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          54d 20h 19m 1 Robbie Gemmell 13/Jul/11 15:56
          In Progress In Progress Reviewable Reviewable
          3s 1 Robbie Gemmell 13/Jul/11 15:56
          Reviewable Reviewable Resolved Resolved
          54d 6h 53m 1 Robbie Gemmell 05/Sep/11 22:50
          Closed Closed Reopened Reopened
          15m 55s 1 Robbie Gemmell 05/Sep/11 23:07
          Reopened Reopened Resolved Resolved
          4s 1 Robbie Gemmell 05/Sep/11 23:07
          Resolved Resolved Closed Closed
          1254d 22h 2 Rob Godfrey 11/Feb/15 20:06

            People

            • Assignee:
              Unassigned
              Reporter:
              Danushka Menikkumbura
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development