[QPID-3263] Java (org.apache.qpid.client) XAResourceImpl always returns false for isSameRM

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.11
• Fix Version/s: 0.14
• Component/s: JMS AMQP 0-x

Environment

All OS/hardware platforms as well as current brokers.

• Assignee: Unassigned
• Reporter: Weston M. Price
• Created: 18/May/11 17:10
• Updated: 14/Mar/17 20:07
• Resolved: 02/Aug/11 15:38

Description

The isSameRM method of org.apache.qpid.client.XAResourceImpl always returns
false.

The javadoc for isSameRM says ..

"This method is called to determine if the resource manager instance
represented by the target object is the same as the resource manager instance
represented by the parameter xares ."

which means isSameRM has to return true when invoked with identical objects
(Java identity). Clearly, these two XA resources are backed by the same
resource manager.

//xaResource1 == xaResource2
XAResource xaResource1 = jmsXAResource;
XAResource xaResource2 = jmsXAResource;

// xaResource1.isSameRM(xaResource2) should be true

Because the Qpid implementation always returns false, it affects resource
enlistment/delistment.

The source code (lines 213 - 217) of org.apache.qpid.client.XAResourceImpl
suggests that this method has not been fully completed.

public boolean isSameRM(XAResource xaResource) throws XAException
{
// TODO : get the server identity of xaResource and compare it with our own one
return false;
}