[QPID-3207] AMQSession.java close() does not close the consumers with the correct arguments

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 0.10
• Component/s: JMS AMQP 0-x
• Assignee: Unassigned
• Reporter: Rajith Muditha Attapattu
• Created: 14/Apr/11 20:42
• Updated: 10/Feb/15 09:53
• Resolved: 10/Feb/15 09:53

Description

When the AMQSession.java close() is invoked it will in turn call the "private void closeConsumers(Throwable error) throws JMSException" method.
In this method if the error is null then the consumer.close method is called with "sendClose=false".

I wonder if this is the correct setting. I suspect the intended value is "true".
The boolean value is used in determining if we should send a message-cancel or not.
I am not sure why we are not going to send a message cancel in this case, as we haven't encountered a session error and the session is active.
Note the AMQSession.java closes the session only after the consumers and producers are closed.

Issue Links

• is related to: QPID-3216 Deadlock between "_lock" (in AMQSession#DisptcherThread) and "_messageDeliveryLock" (in AMQSession.java)
• is related to: QPID-3229 Test AMQConnectionTest#testPrefetchSystemProperty is broken