Qpid
  1. Qpid
  2. QPID-3190

qpid-tool does not allow numeric strings to be passed as strings

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.10
    • Fix Version/s: 0.11
    • Component/s: Python Tools
    • Labels:
      None

      Description

      E.g. if you use the echo method on broker and want to send a body containing the string '1234' you cannot do so. If you quote the string the quotes get included in the argument, of you don't quote it gets converted to an integer and you get a type conversion error back.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/552/
        -----------------------------------------------------------

        Review request for Ted Ross.

        Summary
        -------

        Simply detect tokens starting with one of the quoting chars and always eval them.

        This addresses bug QPID-3190.
        https://issues.apache.org/jira/browse/QPID-3190

        Diffs


        /trunk/qpid/tools/src/py/qpid-tool 1088930

        Diff: https://reviews.apache.org/r/552/diff

        Testing
        -------

        Thanks,

        Gordon

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/552/ ----------------------------------------------------------- Review request for Ted Ross. Summary ------- Simply detect tokens starting with one of the quoting chars and always eval them. This addresses bug QPID-3190 . https://issues.apache.org/jira/browse/QPID-3190 Diffs /trunk/qpid/tools/src/py/qpid-tool 1088930 Diff: https://reviews.apache.org/r/552/diff Testing ------- Thanks, Gordon
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/553/
        -----------------------------------------------------------

        (Updated 2011-04-06 11:33:26.082995)

        Review request for Ted Ross.

        Summary
        -------

        Always try to eval args, but add special case handling for unquoted strings (to keep backward compatibility - alternative would be to require strings to always be quoted).

        This addresses bug QPID-3190.
        https://issues.apache.org/jira/browse/QPID-3190

        Diffs


        /trunk/qpid/tools/src/py/qpid-tool 1088930

        Diff: https://reviews.apache.org/r/553/diff

        Testing
        -------

        Thanks,

        Gordon

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/553/ ----------------------------------------------------------- (Updated 2011-04-06 11:33:26.082995) Review request for Ted Ross. Summary ------- Always try to eval args, but add special case handling for unquoted strings (to keep backward compatibility - alternative would be to require strings to always be quoted). This addresses bug QPID-3190 . https://issues.apache.org/jira/browse/QPID-3190 Diffs /trunk/qpid/tools/src/py/qpid-tool 1088930 Diff: https://reviews.apache.org/r/553/diff Testing ------- Thanks, Gordon
        Hide
        Gordon Sim added a comment -

        Two options available for comment/review: https://reviews.apache.org/r/552/ and https://reviews.apache.org/r/553/

        Show
        Gordon Sim added a comment - Two options available for comment/review: https://reviews.apache.org/r/552/ and https://reviews.apache.org/r/553/
        Hide
        Gordon Sim added a comment -

        Option1 committed.... may still want to revisit the general approach and clean up but that can be done independent of any required fixes now.

        Show
        Gordon Sim added a comment - Option1 committed.... may still want to revisit the general approach and clean up but that can be done independent of any required fixes now.

          People

          • Assignee:
            Gordon Sim
            Reporter:
            Gordon Sim
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development