Qpid
  1. Qpid
  2. QPID-318

Remove hard-coding of protocol version number in the code

    Details

      Description

      After the recent change to support multiple versions of the protocol, a number of instances of hard-coded values for the minor and major version of the protocol had been left in the code.

      Apart from the establishing of the connection by sending the protocol initiation, every other write should use the version established at connection start. To do this we can retain the negotiated version information when on the connection (session) and use these values when we create new frames.

      1. qpid-318.patch
        46 kB
        Rob Godfrey

        Issue Links

          Activity

          Rob Godfrey created issue -
          Hide
          Rob Godfrey added a comment -

          Patch to store negotiated protocol version number in the session, and use this when creating new frames to write.

          As this is essentially a refactoring, no new tests added. however all existing tests (Java , Python, etc) still pass.

          Show
          Rob Godfrey added a comment - Patch to store negotiated protocol version number in the session, and use this when creating new frames to write. As this is essentially a refactoring, no new tests added. however all existing tests (Java , Python, etc) still pass.
          Rob Godfrey made changes -
          Field Original Value New Value
          Attachment qpid-318.patch [ 12349559 ]
          Kim van der Riet made changes -
          Link This issue duplicates QPID-261 [ QPID-261 ]
          Rob Godfrey made changes -
          Assignee Rob Godfrey [ rgodfrey ]
          Rob Godfrey made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s M2.1 [ 12312720 ]
          Gavin made changes -
          Workflow jira [ 12395001 ] QPid [ 12438532 ]
          Gavin made changes -
          Workflow QPid [ 12438532 ] QPid Workflow [ 12439809 ]
          Rob Godfrey made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          321d 11h 56m 1 Rob Godfrey 12/Dec/07 12:22
          Resolved Resolved Closed Closed
          2618d 7h 44m 1 Rob Godfrey 11/Feb/15 20:07

            People

            • Assignee:
              Rob Godfrey
              Reporter:
              Rob Godfrey
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development