Qpid
  1. Qpid
  2. QPID-318

Remove hard-coding of protocol version number in the code

    Details

      Description

      After the recent change to support multiple versions of the protocol, a number of instances of hard-coded values for the minor and major version of the protocol had been left in the code.

      Apart from the establishing of the connection by sending the protocol initiation, every other write should use the version established at connection start. To do this we can retain the negotiated version information when on the connection (session) and use these values when we create new frames.

      1. qpid-318.patch
        46 kB
        Rob Godfrey

        Issue Links

          Activity

          Hide
          Rob Godfrey added a comment -

          Patch to store negotiated protocol version number in the session, and use this when creating new frames to write.

          As this is essentially a refactoring, no new tests added. however all existing tests (Java , Python, etc) still pass.

          Show
          Rob Godfrey added a comment - Patch to store negotiated protocol version number in the session, and use this when creating new frames to write. As this is essentially a refactoring, no new tests added. however all existing tests (Java , Python, etc) still pass.

            People

            • Assignee:
              Rob Godfrey
              Reporter:
              Rob Godfrey
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development