[QPID-3177] JMS Failover Not Working

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.10
• Fix Version/s: 0.10
• Assignee: Robbie Gemmell
• Reporter: Rajith Muditha Attapattu
• Created: 31/Mar/11 21:24
• Updated: 14/Mar/17 20:07
• Resolved: 05/Apr/11 16:06

Description

The JMS failover is not working due to a regression introduced in rev 1071631.
More specifically the reason is the following line being removed.

@@ -257,12 +256,14 @@
ConnectionClose close = exc.getClose();
if (close == null)
{
+ _conn.getProtocolHandler().setFailoverLatch(new CountDownLatch(1));
+
try
{
if (_conn.firePreFailover(false) && _conn.attemptReconnection())

{ _conn.failoverPrep(); - _qpidConnection.resume(); ---- > This line is removed in this commit. + _conn.resubscribeSessions(); _conn.fireFailoverComplete(); return; }

On the surface this seems like a unintended omission. However I'd like to investigate it further and find out if this was intentional.
It if it was, then what was the reason behind it?

The obvious fix is to re-introduce this line. I have done so and preliminary tests indicates that it will resolve the issue. I haven't seen any other issues.
However I'd like to look at more information regarding the context of the above change before making a final decision.