Qpid
  1. Qpid
  2. QPID-3170

Deleting/restoring dynamic federation routes, brokers will not relearn remote bindings that match local keys.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8
    • Fix Version/s: 0.11
    • Component/s: C++ Broker
    • Labels:
      None

      Description

      Should a dynamic federation route be deleted, then restored, remote bindings that use the same key as local bindings are not restored.

      1. QPID-3170-2.patch
        25 kB
        Ken Giusti
      2. pass.sh
        2 kB
        Ken Giusti
      3. fail.sh
        2 kB
        Ken Giusti

        Activity

        Ken Giusti created issue -
        Hide
        Ken Giusti added a comment -

        Test case that exhibits the failure. Note that the binding for "*.Key" to localhost:5673 is not restored after the dynamic route is re-added.

        pass.sh changes the key to be unique, and works as expected.

        Show
        Ken Giusti added a comment - Test case that exhibits the failure. Note that the binding for "*.Key" to localhost:5673 is not restored after the dynamic route is re-added. pass.sh changes the key to be unique, and works as expected.
        Ken Giusti made changes -
        Field Original Value New Value
        Attachment fail.sh [ 12474876 ]
        Attachment pass.sh [ 12474877 ]
        Hide
        Ken Giusti added a comment -

        Proposed patch against trunk.

        Show
        Ken Giusti added a comment - Proposed patch against trunk.
        Ken Giusti made changes -
        Attachment QPID-3170-2.patch [ 12475000 ]
        Hide
        Ken Giusti added a comment -

        Review of patch pending: https://reviews.apache.org/r/533/

        Show
        Ken Giusti added a comment - Review of patch pending: https://reviews.apache.org/r/533/
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/533/#review376
        -----------------------------------------------------------

        Ship it!

        The dynamically-federated exchange code could use some cleanup at some point or some clearer comments around it as it is quite hard to follow and the method/variable names have very little intuitive meaning. However this is a good change and the extra tests are greatly needed.

        • Gordon

        On 2011-03-29 14:38:42, Kenneth Giusti wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/533/

        -----------------------------------------------------------

        (Updated 2011-03-29 14:38:42)

        Review request for Gordon Sim, michael goulish and Ted Ross.

        Summary

        -------

        Potential bugfix for QPID-3170 (BZ681715). Changed the delOrigin() interface to require the remote origin when deleting a route (or a queue). Also made the interface behave correctly if an origin is deleted twice. Added some tests.

        This addresses bug QPID-3170.

        https://issues.apache.org/jira/browse/QPID-3170

        Diffs

        -----

        /trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp 1086404

        /trunk/qpid/cpp/src/qpid/broker/Exchange.h 1086404

        /trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp 1086404

        /trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1086404

        /trunk/qpid/cpp/src/qpid/broker/TopicExchange.h 1086404

        /trunk/qpid/cpp/src/qpid/broker/TopicExchange.cpp 1086404

        /trunk/qpid/cpp/src/tests/federation.py 1086404

        Diff: https://reviews.apache.org/r/533/diff

        Testing

        -------

        make check & additional bug-specific test.

        Thanks,

        Kenneth

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/533/#review376 ----------------------------------------------------------- Ship it! The dynamically-federated exchange code could use some cleanup at some point or some clearer comments around it as it is quite hard to follow and the method/variable names have very little intuitive meaning. However this is a good change and the extra tests are greatly needed. Gordon On 2011-03-29 14:38:42, Kenneth Giusti wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/533/ ----------------------------------------------------------- (Updated 2011-03-29 14:38:42) Review request for Gordon Sim, michael goulish and Ted Ross. Summary ------- Potential bugfix for QPID-3170 (BZ681715). Changed the delOrigin() interface to require the remote origin when deleting a route (or a queue). Also made the interface behave correctly if an origin is deleted twice. Added some tests. This addresses bug QPID-3170 . https://issues.apache.org/jira/browse/QPID-3170 Diffs ----- /trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp 1086404 /trunk/qpid/cpp/src/qpid/broker/Exchange.h 1086404 /trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp 1086404 /trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1086404 /trunk/qpid/cpp/src/qpid/broker/TopicExchange.h 1086404 /trunk/qpid/cpp/src/qpid/broker/TopicExchange.cpp 1086404 /trunk/qpid/cpp/src/tests/federation.py 1086404 Diff: https://reviews.apache.org/r/533/diff Testing ------- make check & additional bug-specific test. Thanks, Kenneth
        Ken Giusti made changes -
        Fix Version/s 0.11 [ 12316272 ]
        Fix Version/s 0.10 [ 12316273 ]
        Ken Giusti made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Justin Ross made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        10d 1h 30m 1 Ken Giusti 08/Apr/11 15:32
        Resolved Resolved Closed Closed
        843d 4h 20m 1 Justin Ross 29/Jul/13 19:52

          People

          • Assignee:
            Ken Giusti
            Reporter:
            Ken Giusti
          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development