Qpid
  1. Qpid
  2. QPID-3144

qpidd --check does not work with info logging and --log-to-stdout=yes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9
    • Fix Version/s: 0.10
    • Component/s: C++ Broker
    • Labels:
      None

      Description

      qpidd --check is supposed to print the PID of a running qpidd --daemon, for use in scripts and the like. However with info logging and log-to-stdout enabled this does not work because log messages of the form:
      2011-03-14 16:21:05 info Loaded Module: /usr/lib64/qpid/daemon/cluster.so
      precede the port number.

        Activity

        Alan Conway created issue -
        Hide
        Alan Conway added a comment -

        Comitted to trunk r1081548, awaiting permission to merge to 0.10 release branch.

        Show
        Alan Conway added a comment - Comitted to trunk r1081548, awaiting permission to merge to 0.10 release branch.
        Hide
        michael j. goulish added a comment -

        Fixing this in the code seems too heavy-handed.
        Also, the log message that is getting in the way is presumably useful in other contexts.

        Wouldn't it be better to simply do something like the following in the affected scripts?

        my_pid=`qpidd --check | grep -v "Loaded"`

        I would propose that we leave this small change out.

        Show
        michael j. goulish added a comment - Fixing this in the code seems too heavy-handed. Also, the log message that is getting in the way is presumably useful in other contexts. Wouldn't it be better to simply do something like the following in the affected scripts? my_pid=`qpidd --check | grep -v "Loaded"` I would propose that we leave this small change out.
        Hide
        Alan Conway added a comment -

        Those log statements are in a precarious position, during plugin loading before things have been properly initialized. IMO they have little to no value and should be removed given that they're causing useful functionality (qpidd --check) to fail in some situations. If we want to log an init message for plugins it should be at plugin initialization (not loading) when things are better set up. Most plugins have their own init logging already, it would be easy to do a global "plugin foo initialized" message as well.

        Show
        Alan Conway added a comment - Those log statements are in a precarious position, during plugin loading before things have been properly initialized. IMO they have little to no value and should be removed given that they're causing useful functionality (qpidd --check) to fail in some situations. If we want to log an init message for plugins it should be at plugin initialization (not loading) when things are better set up. Most plugins have their own init logging already, it would be easy to do a global "plugin foo initialized" message as well.
        Hide
        michael j. goulish added a comment -

        good point about the inappropriate position of these log statements in any case.
        and especially because of teensyness of change – i withdraw my objection.

        nihil obstat.
        imprimatur.

        Show
        michael j. goulish added a comment - good point about the inappropriate position of these log statements in any case. and especially because of teensyness of change – i withdraw my objection. nihil obstat. imprimatur.
        Hide
        Justin Ross added a comment -

        Approved for 0.10. Reviewed by Mick Goulish.

        Show
        Justin Ross added a comment - Approved for 0.10. Reviewed by Mick Goulish.
        Alan Conway made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Justin Ross made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Alan Conway
            Reporter:
            Alan Conway
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development