Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-3122

backward compatibility problem with 0.9 agents

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8
    • Fix Version/s: 0.10
    • Component/s: QMF
    • Labels:
      None

      Description

      The QMF console needs to accept older agent-map keywords as well as the newer ones.

      The attributes advertised in the agent heartbeat include the following keys that were changed in 0.10 for consistency:

      "timestamp" => "_timestamp"
      "heartbeat_interval" => "_heartbeat_interval"
      "epoch" => "_epoch"

        Activity

        Hide
        justi9 Justin Ross added a comment -

        Approved for 0.10. Also reviewed and approved by Ken Giusti.

        Show
        justi9 Justin Ross added a comment - Approved for 0.10. Also reviewed and approved by Ken Giusti.
        Hide
        tedross Ted Ross added a comment -

        There is a second change that was carried in this commit:

        @@ -2416,7 +2427,7 @@
        if uid._class_ == tuple and len(uid) == 2:
        self.saslUser = uid[1]
        else:

        • self.saslUser = None
          + self.saslUser = self.authUser

        This allows the user-id to fall back to the requested username (supplied in the URL) if the saslwrapper library is not installed and in-use. This is related to the change committed in r1071138.

        Show
        tedross Ted Ross added a comment - There is a second change that was carried in this commit: @@ -2416,7 +2427,7 @@ if uid._ class _ == tuple and len(uid) == 2: self.saslUser = uid [1] else: self.saslUser = None + self.saslUser = self.authUser This allows the user-id to fall back to the requested username (supplied in the URL) if the saslwrapper library is not installed and in-use. This is related to the change committed in r1071138.
        Hide
        kgiusti Ken Giusti added a comment -

        There's a change introduced to the python console by this patch that doesn't appear to be related:

        @@ -2416,7 +2427,7 @@
        if uid._class_ == tuple and len(uid) == 2:
        self.saslUser = uid[1]
        else:

        • self.saslUser = None
          + self.saslUser = self.authUser
        1. prevent topic queues from filling up (and causing the agents to
        2. disconnect) by discarding the oldest queued messages when full.

        Is this related?

        Show
        kgiusti Ken Giusti added a comment - There's a change introduced to the python console by this patch that doesn't appear to be related: @@ -2416,7 +2427,7 @@ if uid._ class _ == tuple and len(uid) == 2: self.saslUser = uid [1] else: self.saslUser = None + self.saslUser = self.authUser prevent topic queues from filling up (and causing the agents to disconnect) by discarding the oldest queued messages when full. Is this related?

          People

          • Assignee:
            tedross Ted Ross
            Reporter:
            tedross Ted Ross
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development