Qpid
  1. Qpid
  2. QPID-3064

queues will prevent GC of a closed subscription if it was the last used subscription and no more messages are enqueued

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
    • Fix Version/s: 0.13
    • Component/s: Java Broker
    • Labels:
      None

      Description

      SimpleAMQQueue uses an atomic reference to round robin the subscriptions when attempting to deliver a mesage to a subscription during enqueue operations. This reference will prevent the subscription being Garbage Collected when it is closed if the subscription was the last used and no more messages are enqueued. When unregistering a subscription, this reference should be updated if it points to the closing subscription.

        Activity

        Robbie Gemmell created issue -
        Robbie Gemmell made changes -
        Field Original Value New Value
        Assignee Robbie Gemmell [ gemmellr ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Robbie Gemmell made changes -
        Fix Version/s 0.13 [ 12316854 ]
        Fix Version/s Future [ 12315490 ]
        Affects Version/s 0.10 [ 12316273 ]
        Affects Version/s 0.9 [ 12315382 ]
        Affects Version/s 0.11 [ 12316272 ]
        Affects Version/s 0.12 [ 12316848 ]
        Hide
        Robbie Gemmell added a comment -

        Hi Keith, could you review these changes please?

        The 'last used subscription' marker functionality was moved onto the SubscriptionList itself, and if the marked subscription is deleted a dummy node is inserted to allow the real nodes removal.

        Thanks,
        Robbie.

        Show
        Robbie Gemmell added a comment - Hi Keith, could you review these changes please? The 'last used subscription' marker functionality was moved onto the SubscriptionList itself, and if the marked subscription is deleted a dummy node is inserted to allow the real nodes removal. Thanks, Robbie.
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Keith Wall [ k-wall ]
        Hide
        Keith Wall added a comment -

        Reviewed, no comments from me.

        Show
        Keith Wall added a comment - Reviewed, no comments from me.
        Keith Wall made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        163d 2h 46m 1 Robbie Gemmell 30/Jul/11 16:15
        In Progress In Progress Reviewable Reviewable
        2s 1 Robbie Gemmell 30/Jul/11 16:15
        Reviewable Reviewable Resolved Resolved
        2d 19h 35m 1 Keith Wall 02/Aug/11 11:50
        Resolved Resolved Closed Closed
        1289d 9h 15m 1 Rob Godfrey 11/Feb/15 20:06

          People

          • Assignee:
            Keith Wall
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development