Qpid
  1. Qpid
  2. QPID-3052

Java test profiles do not effectively test all AMQP protocol versions

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9, 0.10, 0.11, 0.12
    • Fix Version/s: 0.15
    • Component/s: Java Tests
    • Labels:
      None

      Description

      The Java test profiles assume that, particularly default one for InVm transports, the 0-10 protocol will fail, causing renegotiation. If 0-10 InVm support is added then the default protocol will use this. It seems to make more sense to specify exactly the version the client and the broker should announce, and force renegotiation explicitly by disabling various protocol versions on the command line when starting an external Java broker. Note that this is not possible to specify for the InVm profiles anyway. Also, the only protocol that is ever tested will be the highest supported by both broker and client, therefore this is AMQP 0-9-1. In order for the tests not to do surprising things when new protocol versions are added, I think that setting versions explicitly is the best idea. I woulsd also like to add an explicit 0-8 test profile for both InVM and external Java brokers, in order to exercise and get coverage on this code.

      In future, I recommend that some form of combinatorial profile system be investigated for the test subsystem, allowing the required protocol, broker type and so on to be specified separately.

        Activity

        Andrew Kennedy created issue -
        Andrew Kennedy made changes -
        Field Original Value New Value
        Fix Version/s 0.11 [ 12316272 ]
        Fix Version/s 0.9 [ 12315382 ]
        Robbie Gemmell made changes -
        Fix Version/s 0.13 [ 12316854 ]
        Fix Version/s 0.11 [ 12316272 ]
        Affects Version/s 0.10 [ 12316273 ]
        Affects Version/s 0.11 [ 12316272 ]
        Affects Version/s 0.12 [ 12316848 ]
        Robbie Gemmell made changes -
        Fix Version/s 0.15 [ 12319043 ]
        Fix Version/s 0.13 [ 12316854 ]
        Robbie Gemmell made changes -
        Assignee Andrew Kennedy [ andrew.kennedy ] Robbie Gemmell [ gemmellr ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Andrew Kennedy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development