Qpid
  1. Qpid
  2. QPID-3039

explicitly define the included debug info instead of relying on defaults which can differ between compilers

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5, 0.6, 0.7, 0.8
    • Fix Version/s: 0.9
    • Component/s: None

      Description

      It'd be good if we can turn on the debugging information of the source by default. A production user must turn them off and re-compile if required.

      Rajika

      1. QPID-3039.patch
        0.6 kB
        Rajika Kumarasiri

        Activity

        Rajika Kumarasiri created issue -
        Hide
        Rajika Kumarasiri added a comment -

        A small patch to fix the problem.

        Rajika

        Show
        Rajika Kumarasiri added a comment - A small patch to fix the problem. Rajika
        Rajika Kumarasiri made changes -
        Field Original Value New Value
        Attachment QPID-3039.patch [ 12470392 ]
        Hide
        Robbie Gemmell added a comment -

        Hi Rajika,

        I have just tested this patch and found it resulted in no difference in the compiled class files, they were 100% binary identical. If I change the new 'debuglevel' definition to be only "lines,source" then my compiled files do differ from normal and become smaller. This would explain why I have never had an issue remote debugging the default output and you have; your compiler obviously has different defaults than mine. Can I ask what JVM/JDK etc you are using?

        The man page for javac (Sun JDK) and the manual page for the Ant javac task suggest that our existing javac usage should indeed result in inclusion of all debug information if using the Sun JDK, and always has in my case. However there is one area of ambiguity where it is mentioned that using javac -g without arguments will include all debug information, but then goes to says that it only generates lines and source debug info by default. My test clearly shows I am seeing the former behaviour, whereas you would seem to have seen the latter behaviour.

        I have applied the patch, but will rename the JIRA to better indicate what is actually being changed.

        Regards,
        Robbie

        Show
        Robbie Gemmell added a comment - Hi Rajika, I have just tested this patch and found it resulted in no difference in the compiled class files, they were 100% binary identical. If I change the new 'debuglevel' definition to be only "lines,source" then my compiled files do differ from normal and become smaller. This would explain why I have never had an issue remote debugging the default output and you have; your compiler obviously has different defaults than mine. Can I ask what JVM/JDK etc you are using? The man page for javac (Sun JDK) and the manual page for the Ant javac task suggest that our existing javac usage should indeed result in inclusion of all debug information if using the Sun JDK, and always has in my case. However there is one area of ambiguity where it is mentioned that using javac -g without arguments will include all debug information, but then goes to says that it only generates lines and source debug info by default. My test clearly shows I am seeing the former behaviour, whereas you would seem to have seen the latter behaviour. I have applied the patch, but will rename the JIRA to better indicate what is actually being changed. Regards, Robbie
        Robbie Gemmell made changes -
        Summary Enable debug info. in the Qpid build by default explicitly define the included debug info instead of relying on defaults which can differ between compilers
        Issue Type Wish [ 5 ] Improvement [ 4 ]
        Assignee Robbie Gemmell [ gemmellr ]
        Fix Version/s 0.9 [ 12315382 ]
        Affects Version/s 0.8 [ 12315477 ]
        Affects Version/s 0.7 [ 12314455 ]
        Affects Version/s 0.6 [ 12313728 ]
        Affects Version/s 0.5 [ 12313597 ]
        Component/s Ant Build System [ 12311471 ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Rob Godfrey made changes -
        Labels ant_build_system
        Rob Godfrey made changes -
        Component/s Ant Build System [ 12311471 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        5h 36m 1 Robbie Gemmell 06/Feb/11 13:55
        In Progress In Progress Resolved Resolved
        18s 1 Robbie Gemmell 06/Feb/11 13:56

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Rajika Kumarasiri
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development