Qpid
  1. Qpid
  2. QPID-3021

the Session and Connector actors should be set for events occurring on 0-10 connections

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8, 0.9
    • Fix Version/s: 0.9
    • Component/s: Java Broker
    • Labels:
      None

      Description

      When addressing QPID-3014 it was noticed that the Session and Connector actors were not being set appropriately when processing events arriving on 0-10 connections. As a result, logging such as session close and connection close do not properly convey the associated LogActor, and instead reported either the actor for the wrong connection that was previously left on the CurrentAActor stack, or jsut the default Broker actor supplied when the stack is empty.

        Activity

        Hide
        Robbie Gemmell added a comment -

        Andrew, can you review the changes please? Thanks.

        Show
        Robbie Gemmell added a comment - Andrew, can you review the changes please? Thanks.
        Hide
        Robbie Gemmell added a comment -

        In working on QPID-3029 it became clear that the 0-10 client/broker was not making use of channel number 0 when infact they could/should be doing so, unlike when using 0-9 where channel 0 represents the connection itself.

        As a result of this, it became clear that enabling that to happen would mean the current check used as reason to set the ConnectionActor for 0-10 connection events such as ConnectionClose is not sufficient (whereby the lack of a particular session being present is used as cause). The connection controls may actually be transmitted using any channel number, which might have an attached session.

        Setting of the connection actor for Connection Control events should be updated to be independent of the channel number of the event.

        Show
        Robbie Gemmell added a comment - In working on QPID-3029 it became clear that the 0-10 client/broker was not making use of channel number 0 when infact they could/should be doing so, unlike when using 0-9 where channel 0 represents the connection itself. As a result of this, it became clear that enabling that to happen would mean the current check used as reason to set the ConnectionActor for 0-10 connection events such as ConnectionClose is not sufficient (whereby the lack of a particular session being present is used as cause). The connection controls may actually be transmitted using any channel number, which might have an attached session. Setting of the connection actor for Connection Control events should be updated to be independent of the channel number of the event.
        Hide
        Robbie Gemmell added a comment -

        Andrew can you review, again ?

        Show
        Robbie Gemmell added a comment - Andrew can you review, again ?
        Hide
        Andrew Kennedy added a comment -

        Review OK

        Show
        Andrew Kennedy added a comment - Review OK

          People

          • Assignee:
            Andrew Kennedy
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development