Qpid
  1. Qpid
  2. QPID-3021

the Session and Connector actors should be set for events occurring on 0-10 connections

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8, 0.9
    • Fix Version/s: 0.9
    • Component/s: Java Broker
    • Labels:
      None

      Description

      When addressing QPID-3014 it was noticed that the Session and Connector actors were not being set appropriately when processing events arriving on 0-10 connections. As a result, logging such as session close and connection close do not properly convey the associated LogActor, and instead reported either the actor for the wrong connection that was previously left on the CurrentAActor stack, or jsut the default Broker actor supplied when the stack is empty.

        Activity

        Robbie Gemmell created issue -
        Robbie Gemmell made changes -
        Field Original Value New Value
        Summary the Session and Connector actors should be set for the Session and Connector actors should be set for events occurring on 0-10 connections
        Assignee Robbie Gemmell [ gemmellr ]
        Fix Version/s 0.9 [ 12315382 ]
        Affects Version/s 0.8 [ 12315477 ]
        Affects Version/s 0.9 [ 12315382 ]
        Priority Major [ 3 ] Minor [ 4 ]
        Description When addressing QPID-3014 it was noticed that the Session and Connector actors were not being set appropriately when processing events arriving on 0-10 connections. As a result, logging such as session close and connection close do not properly convey the associated LogActor, and instead reported either the actor for the wrong connection that was previously left on the CurrentAActor stack, or jsut the default Broker actor supplied when the stack is empty.
        Component/s Java Broker [ 12311388 ]
        Robbie Gemmell made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Priority Minor [ 4 ] Major [ 3 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Robbie Gemmell added a comment -

        Andrew, can you review the changes please? Thanks.

        Show
        Robbie Gemmell added a comment - Andrew, can you review the changes please? Thanks.
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Andrew Kennedy [ andrew.kennedy ]
        Andrew Kennedy made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Robbie Gemmell added a comment -

        In working on QPID-3029 it became clear that the 0-10 client/broker was not making use of channel number 0 when infact they could/should be doing so, unlike when using 0-9 where channel 0 represents the connection itself.

        As a result of this, it became clear that enabling that to happen would mean the current check used as reason to set the ConnectionActor for 0-10 connection events such as ConnectionClose is not sufficient (whereby the lack of a particular session being present is used as cause). The connection controls may actually be transmitted using any channel number, which might have an attached session.

        Setting of the connection actor for Connection Control events should be updated to be independent of the channel number of the event.

        Show
        Robbie Gemmell added a comment - In working on QPID-3029 it became clear that the 0-10 client/broker was not making use of channel number 0 when infact they could/should be doing so, unlike when using 0-9 where channel 0 represents the connection itself. As a result of this, it became clear that enabling that to happen would mean the current check used as reason to set the ConnectionActor for 0-10 connection events such as ConnectionClose is not sufficient (whereby the lack of a particular session being present is used as cause). The connection controls may actually be transmitted using any channel number, which might have an attached session. Setting of the connection actor for Connection Control events should be updated to be independent of the channel number of the event.
        Robbie Gemmell made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Andrew Kennedy [ andrew.kennedy ] Robbie Gemmell [ gemmellr ]
        Robbie Gemmell made changes -
        Status Reopened [ 4 ] In Progress [ 3 ]
        Robbie Gemmell made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Robbie Gemmell added a comment -

        Andrew can you review, again ?

        Show
        Robbie Gemmell added a comment - Andrew can you review, again ?
        Robbie Gemmell made changes -
        Assignee Robbie Gemmell [ gemmellr ] Andrew Kennedy [ andrew.kennedy ]
        Hide
        Andrew Kennedy added a comment -

        Review OK

        Show
        Andrew Kennedy added a comment - Review OK
        Andrew Kennedy made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Rob Godfrey made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        4m 14s 1 Robbie Gemmell 26/Jan/11 16:49
        Resolved Resolved Reopened Reopened
        1d 2h 15m 1 Robbie Gemmell 04/Feb/11 16:02
        Reopened Reopened In Progress In Progress
        12m 31s 1 Robbie Gemmell 04/Feb/11 16:15
        In Progress In Progress Reviewable Reviewable
        18h 34m 2 Robbie Gemmell 04/Feb/11 16:15
        Reviewable Reviewable Resolved Resolved
        26d 22h 58m 2 Andrew Kennedy 24/Feb/11 12:50
        Resolved Resolved Closed Closed
        1448d 7h 15m 1 Rob Godfrey 11/Feb/15 20:06

          People

          • Assignee:
            Andrew Kennedy
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development