Qpid
  1. Qpid
  2. QPID-2899

SelectorTest#testRuntimeSelectorError fails against the Java broker when running the 0-10 profiles

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
    • Fix Version/s: 0.13
    • Component/s: Java Broker
    • Labels:
      None

      Description

      org.apache.qpid.test.client.message.SelectorTest#testRuntimeSelectorError fails against the Java broker when using 0-10 because the broker fails to close the Session when the deliberate error occurs, as it does when using 0-8/0-9.

      QpidBrokerTestCase behaviour is to close connections during teardown that were created using the getConnection() utility method, and the teardown close is failing in this test because it tries to sync outstanding 0-10 commands with the broker and times out, as the previous exception has crippled it. The exception should be caught and used to close the producer Session with an ExecutionException.

        Activity

        Hide
        Keith Wall added a comment -

        Re-reviewed, no further comments.

        Show
        Keith Wall added a comment - Re-reviewed, no further comments.
        Hide
        Robbie Gemmell added a comment -

        No it isnt being logged (it never was), so I have put that in now.

        Show
        Robbie Gemmell added a comment - No it isnt being logged (it never was), so I have put that in now.
        Hide
        Keith Wall added a comment -

        Hi Robbie,

        Are we still logging the exception stack and its underlying(s)? I worry this change might make problem determination more difficult. I'd be tempted to add to the new catch block.

        _logger.error("Exception processing command, e);

        What do you think?

        Show
        Keith Wall added a comment - Hi Robbie, Are we still logging the exception stack and its underlying(s)? I worry this change might make problem determination more difficult. I'd be tempted to add to the new catch block. _logger.error("Exception processing command, e); What do you think?
        Hide
        Robbie Gemmell added a comment -

        Hi Keith, could you review this change please? Thanks.

        Show
        Robbie Gemmell added a comment - Hi Keith, could you review this change please? Thanks.
        Hide
        Robbie Gemmell added a comment -

        Updating 'Fix For' to Unknown on issues not targeted for 0.8

        Show
        Robbie Gemmell added a comment - Updating 'Fix For' to Unknown on issues not targeted for 0.8

          People

          • Assignee:
            Keith Wall
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development