Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-2858

Implement FilterManager for 0-10 subscriptions

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: Java Broker
    • Labels:
      None

      Description

      On 0-10 path, the subscriptions are created with a null FilterManager,

        Activity

        Hide
        sorins Sorin Suciu added a comment -

        Patch committed by Andrew

        Show
        sorins Sorin Suciu added a comment - Patch committed by Andrew
        Hide
        gemmellr Robbie Gemmell added a comment -

        The newly created FilterManager is not used, so the patches amount to a dead code block. The pre-checking and filtering of arguments (not sure the use of .getFields() is correct here, getArguments() possibly?) should not be necessary as the FilterManagerFactory does this itself. The FilterManagerFactorycreation should have a method added that takes the argument Map instead of Fieldtable and then performs the necessary actions, so that functionality for creating FilterManagers is contained in the factory rather than the Subscription.

        Show
        gemmellr Robbie Gemmell added a comment - The newly created FilterManager is not used, so the patches amount to a dead code block. The pre-checking and filtering of arguments (not sure the use of .getFields() is correct here, getArguments() possibly?) should not be necessary as the FilterManagerFactory does this itself. The FilterManagerFactorycreation should have a method added that takes the argument Map instead of Fieldtable and then performs the necessary actions, so that functionality for creating FilterManagers is contained in the factory rather than the Subscription.
        Hide
        andrew.kennedy Andrew Kennedy added a comment -

        Reviewed changes and Committed patch from <sorins@gmail.com>

        Show
        andrew.kennedy Andrew Kennedy added a comment - Reviewed changes and Committed patch from <sorins@gmail.com>

          People

          • Assignee:
            andrew.kennedy Andrew Kennedy
            Reporter:
            sorins Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development