Qpid
  1. Qpid
  2. QPID-2858

Implement FilterManager for 0-10 subscriptions

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: Java Broker
    • Labels:
      None

      Description

      On 0-10 path, the subscriptions are created with a null FilterManager,

        Activity

        Sorin Suciu created issue -
        Sorin Suciu made changes -
        Field Original Value New Value
        Attachment qpid-2858.patch [ 12454839 ]
        Sorin Suciu made changes -
        Attachment qpid-2858.patch [ 12454846 ]
        Sorin Suciu made changes -
        Attachment qpid-2858.patch [ 12454839 ]
        Hide
        Andrew Kennedy added a comment -

        Reviewed changes and Committed patch from <sorins@gmail.com>

        Show
        Andrew Kennedy added a comment - Reviewed changes and Committed patch from <sorins@gmail.com>
        Andrew Kennedy made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Sorin Suciu made changes -
        Attachment qpid-2858_1.patch [ 12454859 ]
        Hide
        Robbie Gemmell added a comment -

        The newly created FilterManager is not used, so the patches amount to a dead code block. The pre-checking and filtering of arguments (not sure the use of .getFields() is correct here, getArguments() possibly?) should not be necessary as the FilterManagerFactory does this itself. The FilterManagerFactorycreation should have a method added that takes the argument Map instead of Fieldtable and then performs the necessary actions, so that functionality for creating FilterManagers is contained in the factory rather than the Subscription.

        Show
        Robbie Gemmell added a comment - The newly created FilterManager is not used, so the patches amount to a dead code block. The pre-checking and filtering of arguments (not sure the use of .getFields() is correct here, getArguments() possibly?) should not be necessary as the FilterManagerFactory does this itself. The FilterManagerFactorycreation should have a method added that takes the argument Map instead of Fieldtable and then performs the necessary actions, so that functionality for creating FilterManagers is contained in the factory rather than the Subscription.
        Robbie Gemmell made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Andrew Kennedy [ andrew.kennedy ]
        Sorin Suciu made changes -
        Attachment qpid-2858_1.patch [ 12455028 ]
        Sorin Suciu made changes -
        Attachment qpid-2858_1.patch [ 12454859 ]
        Sorin Suciu made changes -
        Attachment qpid-2858.patch [ 12454846 ]
        Hide
        Sorin Suciu added a comment -

        Patch committed by Andrew

        Show
        Sorin Suciu added a comment - Patch committed by Andrew
        Sorin Suciu made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Sorin Suciu made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        2d 3h 7m 1 Andrew Kennedy 17/Sep/10 13:43
        Resolved Resolved Reopened Reopened
        2d 19h 29m 1 Robbie Gemmell 20/Sep/10 09:12
        Reopened Reopened Resolved Resolved
        3d 7h 21m 1 Sorin Suciu 23/Sep/10 16:34
        Resolved Resolved Closed Closed
        52s 1 Sorin Suciu 23/Sep/10 16:35

          People

          • Assignee:
            Andrew Kennedy
            Reporter:
            Sorin Suciu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development